diff --git a/src/env.cc b/src/env.cc index 023e69665d94ed..ed6717d684421b 100644 --- a/src/env.cc +++ b/src/env.cc @@ -65,7 +65,7 @@ class TraceEventScope { }; int const Environment::kNodeContextTag = 0x6e6f64; -void* Environment::kNodeContextTagPtr = const_cast( +void* const Environment::kNodeContextTagPtr = const_cast( static_cast(&Environment::kNodeContextTag)); IsolateData::IsolateData(Isolate* isolate, diff --git a/src/env.h b/src/env.h index ec0368e040a608..8363a7cee30004 100644 --- a/src/env.h +++ b/src/env.h @@ -971,7 +971,7 @@ class Environment { uint64_t thread_id_ = 0; std::unordered_set sub_worker_contexts_; - static void* kNodeContextTagPtr; + static void* const kNodeContextTagPtr; static int const kNodeContextTag; #if HAVE_INSPECTOR diff --git a/src/node_file.cc b/src/node_file.cc index fdb0406f60a981..ae34d90a2d026a 100644 --- a/src/node_file.cc +++ b/src/node_file.cc @@ -81,9 +81,9 @@ using v8::Value; #endif #ifdef __POSIX__ -const char* kPathSeparator = "/"; +constexpr char kPathSeparator = '/'; #else -const char* kPathSeparator = "\\/"; +const char* const kPathSeparator = "\\/"; #endif #define GET_OFFSET(a) ((a)->IsNumber() ? (a).As()->Value() : -1) diff --git a/src/node_http_parser_llhttp.cc b/src/node_http_parser_llhttp.cc index 7b9999d13c7cce..8728fa2b677403 100644 --- a/src/node_http_parser_llhttp.cc +++ b/src/node_http_parser_llhttp.cc @@ -4,7 +4,7 @@ namespace node { -const char* llhttp_version = +const char* const llhttp_version = NODE_STRINGIFY(LLHTTP_VERSION_MAJOR) "." NODE_STRINGIFY(LLHTTP_VERSION_MINOR) diff --git a/src/node_http_parser_traditional.cc b/src/node_http_parser_traditional.cc index 2bff20c1656020..2ea452239a0a1d 100644 --- a/src/node_http_parser_traditional.cc +++ b/src/node_http_parser_traditional.cc @@ -6,7 +6,7 @@ namespace node { -const char* http_parser_version = +const char* const http_parser_version = NODE_STRINGIFY(HTTP_PARSER_VERSION_MAJOR) "." NODE_STRINGIFY(HTTP_PARSER_VERSION_MINOR) diff --git a/src/node_internals.h b/src/node_internals.h index 1d43d4b1419b9c..9c0b8ac3a7b906 100644 --- a/src/node_internals.h +++ b/src/node_internals.h @@ -697,8 +697,8 @@ static inline const char* errno_string(int errorno) { extern double prog_start_time; -extern const char* llhttp_version; -extern const char* http_parser_version; +extern const char* const llhttp_version; +extern const char* const http_parser_version; void Abort(const v8::FunctionCallbackInfo& args); void Chdir(const v8::FunctionCallbackInfo& args); diff --git a/src/node_postmortem_metadata.cc b/src/node_postmortem_metadata.cc index 93bf5a4dd7d8f4..527bfb623e65de 100644 --- a/src/node_postmortem_metadata.cc +++ b/src/node_postmortem_metadata.cc @@ -60,6 +60,6 @@ int GenDebugSymbols() { return 1; } -int debug_symbols_generated = GenDebugSymbols(); +const int debug_symbols_generated = GenDebugSymbols(); } // namespace node