Skip to content

Commit

Permalink
test: remove checks for deserializing wasm
Browse files Browse the repository at this point in the history
V8 is removing support for serializing wasm modules via the value
serializer. Once this is complete (https://crrev.com/c/2013110), we can
re-add this test.

PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
mmarchini committed Mar 18, 2020
1 parent a63db7f commit 119fdf6
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions test/parallel/test-v8-serdes.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
'use strict';

const common = require('../common');
const fixtures = require('../common/fixtures');
const { internalBinding } = require('internal/test/binding');
const assert = require('assert');
const v8 = require('v8');
Expand All @@ -12,8 +11,6 @@ const os = require('os');
const circular = {};
circular.circular = circular;

const wasmModule = new WebAssembly.Module(fixtures.readSync('simple.wasm'));

const objects = [
{ foo: 'bar' },
{ bar: 'baz' },
Expand All @@ -23,8 +20,7 @@ const objects = [
undefined,
null,
42,
circular,
wasmModule
circular
];

const hostObject = new (internalBinding('js_stream').JSStream)();
Expand Down Expand Up @@ -236,9 +232,3 @@ const deserializerTypeError =
/^TypeError: buffer must be a TypedArray or a DataView$/,
);
}

{
const deserializedWasmModule = v8.deserialize(v8.serialize(wasmModule));
const instance = new WebAssembly.Instance(deserializedWasmModule);
assert.strictEqual(instance.exports.add(10, 20), 30);
}

0 comments on commit 119fdf6

Please sign in to comment.