Skip to content

Commit

Permalink
test: move known issue test to parallel
Browse files Browse the repository at this point in the history
As of libuv 1.28.0, this bug is fixed, and the test can be
moved to parallel. This commit also updates an error code
check to work on Windows.

Backport-PR-URL: #27776
PR-URL: #27241
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
cjihrig authored and MylesBorins committed May 20, 2019
1 parent 4c87c1b commit 1fc2c5b
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ function beforeEach() {
fs.chmodSync(dest, '444');

const check = (err) => {
assert.strictEqual(err.code, 'EACCES');
const expected = ['EACCES', 'EPERM'];
assert(expected.includes(err.code), `${err.code} not in ${expected}`);
assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'dest');
return true;
};
Expand Down

0 comments on commit 1fc2c5b

Please sign in to comment.