benchmark: fix next-tick-depth

A recent change made these benchmarks fail by always finishing with 0 iterations. Restore a counter variable. PR-URL: #20461 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs · May 8, 2018 · 289e4ce · 289e4ce
1 parent 7a769eb
commit 289e4ce
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 18 deletions.
diff --git a/benchmark/process/next-tick-depth-args.js b/benchmark/process/next-tick-depth-args.js
@@ -8,52 +8,53 @@ const bench = common.createBenchmark(main, {
 process.maxTickDepth = Infinity;
 
 function main({ n }) {
+  let counter = n;
   function cb4(arg1, arg2, arg3, arg4) {
-    if (--n) {
-      if (n % 4 === 0)
+    if (--counter) {
+      if (counter % 4 === 0)
         process.nextTick(cb4, 3.14, 1024, true, false);
-      else if (n % 3 === 0)
+      else if (counter % 3 === 0)
         process.nextTick(cb3, 512, true, null);
-      else if (n % 2 === 0)
+      else if (counter % 2 === 0)
         process.nextTick(cb2, false, 5.1);
       else
         process.nextTick(cb1, 0);
     } else
       bench.end(n);
   }
   function cb3(arg1, arg2, arg3) {
-    if (--n) {
-      if (n % 4 === 0)
+    if (--counter) {
+      if (counter % 4 === 0)
         process.nextTick(cb4, 3.14, 1024, true, false);
-      else if (n % 3 === 0)
+      else if (counter % 3 === 0)
         process.nextTick(cb3, 512, true, null);
-      else if (n % 2 === 0)
+      else if (counter % 2 === 0)
         process.nextTick(cb2, false, 5.1);
       else
         process.nextTick(cb1, 0);
     } else
       bench.end(n);
   }
   function cb2(arg1, arg2) {
-    if (--n) {
-      if (n % 4 === 0)
+    if (--counter) {
+      if (counter % 4 === 0)
         process.nextTick(cb4, 3.14, 1024, true, false);
-      else if (n % 3 === 0)
+      else if (counter % 3 === 0)
         process.nextTick(cb3, 512, true, null);
-      else if (n % 2 === 0)
+      else if (counter % 2 === 0)
         process.nextTick(cb2, false, 5.1);
       else
         process.nextTick(cb1, 0);
     } else
       bench.end(n);
   }
   function cb1(arg1) {
-    if (--n) {
-      if (n % 4 === 0)
+    if (--counter) {
+      if (counter % 4 === 0)
         process.nextTick(cb4, 3.14, 1024, true, false);
-      else if (n % 3 === 0)
+      else if (counter % 3 === 0)
         process.nextTick(cb3, 512, true, null);
-      else if (n % 2 === 0)
+      else if (counter % 2 === 0)
         process.nextTick(cb2, false, 5.1);
       else
         process.nextTick(cb1, 0);

diff --git a/benchmark/process/next-tick-depth.js b/benchmark/process/next-tick-depth.js
@@ -7,11 +7,11 @@ const bench = common.createBenchmark(main, {
 process.maxTickDepth = Infinity;
 
 function main({ n }) {
-
+  let counter = n;
   bench.start();
   process.nextTick(onNextTick);
   function onNextTick() {
-    if (--n)
+    if (--counter)
       process.nextTick(onNextTick);
     else
       bench.end(n);