From 304bbd51279dcdde6ff5eedb3cd0657bc3af95ea Mon Sep 17 00:00:00 2001 From: Alois Klink Date: Sun, 30 Jul 2023 17:03:01 +0100 Subject: [PATCH] test: test pipeline `end` on transform streams Add test that confirms that `stream.promises.pipeline(source, transform, dest, {end: false});` only skips ending the destination stream. `{end: false}` should still end any transform streams. PR-URL: https://github.com/nodejs/node/pull/48970 Reviewed-By: Luigi Pinca --- test/parallel/test-stream-pipeline.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-stream-pipeline.js b/test/parallel/test-stream-pipeline.js index 915a035264c7a7..8237fff33b3ac8 100644 --- a/test/parallel/test-stream-pipeline.js +++ b/test/parallel/test-stream-pipeline.js @@ -1476,10 +1476,14 @@ const tsp = require('timers/promises'); }); const duplex = new PassThrough(); + const transform = new PassThrough(); read.push(null); - await pipelinePromise(read, duplex, { end: false }); + await pipelinePromise(read, transform, duplex, { end: false }); + + assert.strictEqual(transform.destroyed, true); + assert.strictEqual(transform.writableEnded, true); assert.strictEqual(duplex.destroyed, false); assert.strictEqual(duplex.writableEnded, false);