From 65924c70e8248569877da493a62066d9359417ec Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Wed, 23 May 2018 13:10:53 +0200 Subject: [PATCH] src: remove unused fields isolate_ Currently the following compiler warnings are generated: In file included from ../src/node_platform.cc:1: ../src/node_platform.h:83:16: warning: private field 'isolate_' is not used [-Wunused-private-field] v8::Isolate* isolate_; ^ 1 warning generated. This commit removes these unused private member. PR-URL: https://github.com/nodejs/node/pull/20876 Reviewed-By: Gireesh Punathil Reviewed-By: Benjamin Gruenbaum Reviewed-By: Shingo Inoue Reviewed-By: Matteo Collina Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: John-David Dalton Reviewed-By: Gus Caplan --- src/node_platform.cc | 2 +- src/node_platform.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/node_platform.cc b/src/node_platform.cc index 6fc83950d3083e..f2407f5be2d3c8 100644 --- a/src/node_platform.cc +++ b/src/node_platform.cc @@ -65,7 +65,7 @@ size_t BackgroundTaskRunner::NumberOfAvailableBackgroundThreads() const { PerIsolatePlatformData::PerIsolatePlatformData( v8::Isolate* isolate, uv_loop_t* loop) - : isolate_(isolate), loop_(loop) { + : loop_(loop) { flush_tasks_ = new uv_async_t(); CHECK_EQ(0, uv_async_init(loop, flush_tasks_, FlushTasks)); flush_tasks_->data = static_cast(this); diff --git a/src/node_platform.h b/src/node_platform.h index 8f6ff89f491fe3..cf0809ad1f673b 100644 --- a/src/node_platform.h +++ b/src/node_platform.h @@ -80,7 +80,6 @@ class PerIsolatePlatformData : static void RunForegroundTask(uv_timer_t* timer); int ref_count_ = 1; - v8::Isolate* isolate_; uv_loop_t* const loop_; uv_async_t* flush_tasks_ = nullptr; TaskQueue foreground_tasks_;