Skip to content

Commit

Permalink
deps: V8: cherry-pick 931bdbd76f5b
Browse files Browse the repository at this point in the history
Original commit message:

    [torque] fix build on VS2017

    Node.js build fails on VS2017 without these headers, see the downstream
    issue (nodejs/node-v8#128).

    Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
    Co-authored-by: gengjiawen <technicalcute@gmail.com>
    Change-Id: I771eab435dce5cf548581f3acd78681180c77692
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093951
    Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66661}

Refs: v8/v8@931bdbd

PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
mmarchini committed Mar 18, 2020
1 parent 049160d commit 8d2c441
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.8',
'v8_embedder_string': '-node.9',

##### V8 defaults for Node.js #####

Expand Down
20 changes: 20 additions & 0 deletions deps/v8/src/torque/implementation-visitor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3964,6 +3964,26 @@ void ImplementationVisitor::GenerateExportedMacrosAssembler(
h_contents << "#include \"torque-generated/csa-types-tq.h\"\n";
h_contents
<< "#include \"torque-generated/internal-class-definitions-tq.h\"\n";
cc_contents << "#include \"src/objects/free-space.h\"\n";
cc_contents << "#include \"src/objects/js-regexp-string-iterator.h\"\n";
cc_contents << "#include \"src/objects/ordered-hash-table.h\"\n";
cc_contents << "#include \"src/objects/property-descriptor-object.h\"\n";
cc_contents << "#include \"src/objects/synthetic-module.h\"\n";
cc_contents << "#include \"src/objects/template-objects.h\"\n";
{
IfDefScope intl_scope(cc_contents, "V8_INTL_SUPPORT");
cc_contents << "#include \"src/objects/js-break-iterator.h\"\n";
cc_contents << "#include \"src/objects/js-collator.h\"\n";
cc_contents << "#include \"src/objects/js-date-time-format.h\"\n";
cc_contents << "#include \"src/objects/js-display-names.h\"\n";
cc_contents << "#include \"src/objects/js-list-format.h\"\n";
cc_contents << "#include \"src/objects/js-locale.h\"\n";
cc_contents << "#include \"src/objects/js-number-format.h\"\n";
cc_contents << "#include \"src/objects/js-plural-rules.h\"\n";
cc_contents << "#include \"src/objects/js-relative-time-format.h\"\n";
cc_contents << "#include \"src/objects/js-segment-iterator.h\"\n";
cc_contents << "#include \"src/objects/js-segmenter.h\"\n";
}
cc_contents << "#include \"torque-generated/" << file_name << ".h\"\n";

for (SourceId file : SourceFileMap::AllSources()) {
Expand Down

0 comments on commit 8d2c441

Please sign in to comment.