Skip to content

Commit

Permalink
build: compile with C++17 (MSVC)
Browse files Browse the repository at this point in the history
PR-URL: #38807
Refs: #38788
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
  • Loading branch information
richardlau authored and nodejs-github-bot committed Oct 13, 2021
1 parent 228e703 commit 9dfa30b
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,10 @@
],
'msvs_settings': {
'VCCLCompilerTool': {
'AdditionalOptions': ['/Zc:__cplusplus'],
'AdditionalOptions': [
'/Zc:__cplusplus',
'-std:c++17'
],
'BufferSecurityCheck': 'true',
'DebugInformationFormat': 1, # /Z7 embed info in .obj files
'ExceptionHandling': 0, # /EHsc
Expand Down

0 comments on commit 9dfa30b

Please sign in to comment.