Skip to content

Commit

Permalink
tools: fix --v8-non-optimized-debug for v18.x
Browse files Browse the repository at this point in the history
Disable SLOW_DCHECKs on v18.x because they don't compile without
the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887
if used in constexpr, which can happen in other floated patches.

PR-URL: #50612
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
joyeecheung authored and targos committed Nov 27, 2023
1 parent 7af5427 commit a1c9403
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tools/v8_gypfiles/features.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@
# Set to 1 to enable DCHECKs in release builds.
'dcheck_always_on%': 0,

# For v18.x, disable SLOW_DCHECKs because they don't compile without
# the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887
# if used in constexpr, which can happen in other floated patches.
'v8_enable_slow_dchecks%': 0,

# Sets -DV8_ENABLE_FUTURE.
'v8_enable_future%': 0,

Expand Down

0 comments on commit a1c9403

Please sign in to comment.