From a1c94037abb5d154d61e387ef45865de84a56c53 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Tue, 7 Nov 2023 15:38:30 +0000 Subject: [PATCH] tools: fix --v8-non-optimized-debug for v18.x MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Disable SLOW_DCHECKs on v18.x because they don't compile without the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887 if used in constexpr, which can happen in other floated patches. PR-URL: https://github.com/nodejs/node/pull/50612 Reviewed-By: Michaël Zasso --- tools/v8_gypfiles/features.gypi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/v8_gypfiles/features.gypi b/tools/v8_gypfiles/features.gypi index 3c94b0bca4c383..aa59713bbbe9ed 100644 --- a/tools/v8_gypfiles/features.gypi +++ b/tools/v8_gypfiles/features.gypi @@ -90,6 +90,11 @@ # Set to 1 to enable DCHECKs in release builds. 'dcheck_always_on%': 0, + # For v18.x, disable SLOW_DCHECKs because they don't compile without + # the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887 + # if used in constexpr, which can happen in other floated patches. + 'v8_enable_slow_dchecks%': 0, + # Sets -DV8_ENABLE_FUTURE. 'v8_enable_future%': 0,