Skip to content

Commit

Permalink
os: move tmpDir() to EOL
Browse files Browse the repository at this point in the history
The tmpDir alias was deprecated in 7.0.0

PR-URL: #31169
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
jasnell committed Feb 6, 2020
1 parent ec0dd6f commit ab4115f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
8 changes: 6 additions & 2 deletions doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -519,14 +519,18 @@ The `Server.listenFD()` method was deprecated and removed. Please use
### DEP0022: `os.tmpDir()`
<!-- YAML
changes:
- version: REPLACEME
pr-url: REPLACEME
description: End-of-Life.
- version: v7.0.0
pr-url: https://github.com/nodejs/node/pull/6739
description: Runtime deprecation.
-->

Type: Runtime
Type: End-of-Life

The `os.tmpDir()` API is deprecated. Please use [`os.tmpdir()`][] instead.
The `os.tmpDir()` API iws deprecated in Node.js 7.0.0 and has since been
removed. Please use [`os.tmpdir()`][] instead.

<a id="DEP0023"></a>
### DEP0023: `os.getNetworkInterfaces()`
Expand Down
7 changes: 0 additions & 7 deletions lib/os.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const {

const { safeGetenv } = internalBinding('credentials');
const constants = internalBinding('constants').os;
const { deprecate } = require('internal/util');
const isWindows = process.platform === 'win32';

const {
Expand Down Expand Up @@ -83,9 +82,6 @@ getUptime[SymbolToPrimitive] = () => getUptime();

const kEndianness = isBigEndian ? 'BE' : 'LE';

const tmpDirDeprecationMsg =
'os.tmpDir() is deprecated. Use os.tmpdir() instead.';

const avgValues = new Float64Array(3);

function loadavg() {
Expand Down Expand Up @@ -285,9 +281,6 @@ module.exports = {
type: getOSType,
userInfo,
uptime: getUptime,

// Deprecated APIs
tmpDir: deprecate(tmpdir, tmpDirDeprecationMsg, 'DEP0022')
};

ObjectDefineProperties(module.exports, {
Expand Down

0 comments on commit ab4115f

Please sign in to comment.