From e08fd98bcc40e40c0404ce096a13a2dff8f7272e Mon Sep 17 00:00:00 2001
From: Jordan Harband <ljharb@gmail.com>
Date: Tue, 11 Jul 2023 23:21:40 -0700
Subject: [PATCH] bootstrap: use correct descriptor for
 Symbol.{dispose,asyncDispose}

Followup to #48518; fixes #48699

PR-URL: https://github.com/nodejs/node/pull/48703
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
---
 lib/internal/process/pre_execution.js | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/lib/internal/process/pre_execution.js b/lib/internal/process/pre_execution.js
index f8f34f25f0c163..3b9dfb01452c81 100644
--- a/lib/internal/process/pre_execution.js
+++ b/lib/internal/process/pre_execution.js
@@ -120,9 +120,26 @@ function prepareExecution(options) {
 function setupSymbolDisposePolyfill() {
   // TODO(MoLow): Remove this polyfill once Symbol.dispose and Symbol.asyncDispose are available in V8.
   // eslint-disable-next-line node-core/prefer-primordials
-  Symbol.dispose ??= SymbolDispose;
+  if (typeof Symbol.dispose !== 'symbol') {
+    ObjectDefineProperty(Symbol, 'dispose', {
+      __proto__: null,
+      configurable: false,
+      enumerable: false,
+      value: SymbolDispose,
+      writable: false,
+    });
+  }
+
   // eslint-disable-next-line node-core/prefer-primordials
-  Symbol.asyncDispose ??= SymbolAsyncDispose;
+  if (typeof Symbol.asyncDispose !== 'symbol') {
+    ObjectDefineProperty(Symbol, 'asyncDispose', {
+      __proto__: null,
+      configurable: false,
+      enumerable: false,
+      value: SymbolAsyncDispose,
+      writable: false,
+    });
+  }
 }
 
 function setupUserModules(isLoaderWorker = false) {