From f0df222e821b0e3f55e8fdb7682d0d8dd9c69117 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Mon, 22 Apr 2019 04:21:02 +0200 Subject: [PATCH] util: rename setIteratorBraces to getIteratorBraces The function is actually a getter, not a setter. PR-URL: https://github.com/nodejs/node/pull/27342 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Anna Henningsen --- lib/internal/util/inspect.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js index d20c7b93c92ceb..4def103f42adeb 100644 --- a/lib/internal/util/inspect.js +++ b/lib/internal/util/inspect.js @@ -560,15 +560,6 @@ function formatValue(ctx, value, recurseTimes, typedArray) { return formatRaw(ctx, value, recurseTimes, typedArray); } -function setIteratorBraces(type, tag) { - if (tag !== `${type} Iterator`) { - if (tag !== '') - tag += '] ['; - tag += `${type} Iterator`; - } - return [`[${tag}] {`, '}']; -} - function formatRaw(ctx, value, recurseTimes, typedArray) { let keys; @@ -630,11 +621,11 @@ function formatRaw(ctx, value, recurseTimes, typedArray) { extrasType = kArrayExtrasType; } else if (isMapIterator(value)) { keys = getKeys(value, ctx.showHidden); - braces = setIteratorBraces('Map', tag); + braces = getIteratorBraces('Map', tag); formatter = formatIterator; } else if (isSetIterator(value)) { keys = getKeys(value, ctx.showHidden); - braces = setIteratorBraces('Set', tag); + braces = getIteratorBraces('Set', tag); formatter = formatIterator; } else { noIterator = true; @@ -754,10 +745,10 @@ function formatRaw(ctx, value, recurseTimes, typedArray) { } } if (isMapIterator(value)) { - braces = setIteratorBraces('Map', tag); + braces = getIteratorBraces('Map', tag); formatter = formatIterator; } else if (isSetIterator(value)) { - braces = setIteratorBraces('Set', tag); + braces = getIteratorBraces('Set', tag); formatter = formatIterator; // Handle other regular objects again. } else if (keys.length === 0) { @@ -818,6 +809,15 @@ function formatRaw(ctx, value, recurseTimes, typedArray) { return res; } +function getIteratorBraces(type, tag) { + if (tag !== `${type} Iterator`) { + if (tag !== '') + tag += '] ['; + tag += `${type} Iterator`; + } + return [`[${tag}] {`, '}']; +} + function formatError(err, constructor, tag, ctx) { // TODO(BridgeAR): Always show the error code if present. let stack = err.stack || ErrorPrototype.toString(err);