Skip to content

Commit

Permalink
fs: fix read / readSync positional offset types
Browse files Browse the repository at this point in the history
This changeset fixes the types in comments to match the implementation.

PR-URL: #52603
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
ruyadorno authored and aduh95 committed Apr 29, 2024
1 parent 3552829 commit f23fa1d
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions lib/fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,11 @@ function openAsBlob(path, options = kEmptyObject) {
* Reads file from the specified `fd` (file descriptor).
* @param {number} fd
* @param {Buffer | TypedArray | DataView} buffer
* @param {number} offsetOrOptions
* @param {number | {
* offset?: number;
* length?: number;
* position?: number | bigint | null;
* }} [offsetOrOptions]
* @param {number} length
* @param {number | bigint | null} position
* @param {(
Expand Down Expand Up @@ -693,7 +697,7 @@ ObjectDefineProperty(read, kCustomPromisifyArgsSymbol,
* specified `fd` (file descriptor).
* @param {number} fd
* @param {Buffer | TypedArray | DataView} buffer
* @param {{
* @param {number | {
* offset?: number;
* length?: number;
* position?: number | bigint | null;
Expand Down

0 comments on commit f23fa1d

Please sign in to comment.