Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What counts as "activity" for Http2Session#setTimeout? #21582

Closed
murgatroid99 opened this issue Jun 28, 2018 · 4 comments
Closed

What counts as "activity" for Http2Session#setTimeout? #21582

murgatroid99 opened this issue Jun 28, 2018 · 4 comments
Labels
http2 Issues or PRs related to the http2 subsystem.

Comments

@murgatroid99
Copy link
Contributor

The documentation says

Used to set a callback function that is called when there is no activity on the Http2Session after msecs milliseconds.

What exactly counts as "activity" there?
@murgatroid99
Copy link
Contributor Author

More specifically: does all incoming data count? Do writes initiated by the local application count? Does every kind of http2 frame count, or just some of them?

@TimothyGu
Copy link
Member

/cc @nodejs/http2

@TimothyGu TimothyGu added the http2 Issues or PRs related to the http2 subsystem. label Jul 3, 2018
@mcollina
Copy link
Member

mcollina commented Jul 5, 2018

More specifically: does all incoming data count? Do writes initiated by the local application count? Does every kind of http2 frame count, or just some of them?

To my best understading, I think all data transfered (both ways) count.

@apapirovski
Copy link
Member

Everything but WINDOW_UPDATE frames should count.

@snyk-bot snyk-bot mentioned this issue Mar 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@apapirovski @mcollina @murgatroid99 @TimothyGu