Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x needs a backport] - assert: improve loose assertion message #22711

Closed
targos opened this issue Sep 5, 2018 · 3 comments
Closed

[v10.x needs a backport] - assert: improve loose assertion message #22711

targos opened this issue Sep 5, 2018 · 3 comments
Labels
assert Issues and PRs related to the assert subsystem. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.

Comments

@targos
Copy link
Member

targos commented Sep 5, 2018

PR: #22155

/cc @BridgeAR

Feel free to close this issue if the PR should not be backported, but please swap the labels there.
@targos targos added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. v10.x assert Issues and PRs related to the assert subsystem. labels Sep 5, 2018
@oyyd oyyd mentioned this issue Sep 26, 2018
Closed
2 tasks
@targos
Copy link
Member Author

targos commented Sep 27, 2018

@BridgeAR Do you think the PR (or part of it) should be backported?

@BridgeAR
Copy link
Member

I guess it would be nice, even though the loose mode is not used that much. I'll have a look into backporting a couple of things today.

@BridgeAR
Copy link
Member

BridgeAR commented Oct 2, 2018

Closing as the PR actually relies on a semver-major change.

@BridgeAR BridgeAR closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @BridgeAR