Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify where pull requests should go #407

Closed
RubenVerborgh opened this issue Jan 14, 2015 · 4 comments
Closed

Clarify where pull requests should go #407

RubenVerborgh opened this issue Jan 14, 2015 · 4 comments

Comments

@RubenVerborgh
Copy link
Contributor

Given the large overlap of codebase between Node.js and io.js, it is often not easy for contributors to understand where to send patches. For instance, the two pull requests below express the exact same changes in the different projects:

What is the proper procedure?
Only create one pull request (where?) and hope it eventually gets merged in both?
Or create to pull requests like I have just done?

Maybe it would be good to clarify this in the contributors guidelines.

@mikeal
Copy link
Contributor

mikeal commented Jan 14, 2015

Send all patches here :)

@ryanseys
Copy link
Contributor

I think this is up to the contributor. Of course @mikeal wants you to land it here! 😉

@RubenVerborgh
Copy link
Contributor Author

But what's best for the ecosystem? Submitting it to both then?

@bnoordhuis
Copy link
Member

If it lands in joyent/node and it's noteworthy / useful enough, we'll eventually cherry-pick it into io.js. joyent/node is not known for high speed patch reviews, however; that's one of the reasons io.js exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants