Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert end-users to features that were added to Node.js core when using a package/shim/etc #116

Open
joesepi opened this issue Jun 25, 2021 · 2 comments

Comments

@joesepi
Copy link
Member

joesepi commented Jun 25, 2021

We've started incorporating some third-party packages like mkdirp and rimraf into Node core. We should figure out a way to flag this to users if they're using the package in their code. In some cases the npm packages provide additional functionality, for example rimraf also provides binlinks so we probably only want to flag certain usages.

Related: #110

@ljharb
Copy link
Member

ljharb commented Jun 25, 2021

If the node runtime is going to do this (it probably should be an eslint plugin instead), it must:

  • never flag third-party code (ie, inside node_modules) because that's not actionable
  • not flag first-party code when the "engines" field declares support for a version of node that lacks the core module, because that would likely cause unexpected breakage for consumers

@iansu
Copy link
Contributor

iansu commented Jul 9, 2021

We discussed this in the tooling meeting today and had the idea of creating a small standalone package you could run in a project that would scan your code and dependencies and generate a list of recommendations for moving from third-party packages to built in functionality. We're going to build a prototype of this and see how it works. We're still open to other ideas as well though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants