Add the possibility to listen on a specific host #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalvdans
reviewed
Oct 11, 2023
afbjorklund
force-pushed
the
listen-host
branch
from
68d88e9
to
ffb409a
Compare
|
It's more complicated that it needs to be, but it is fine that it just passes the argument unmodified to websockify, and the complications are only for pretty-printing. LGTM besides my small remarks. |
kalvdans
reviewed
Oct 11, 2023
For instance, for listening only on "localhost" That is, bind on 127.0.0.1 instead of 0.0.0.0
afbjorklund
force-pushed
the
listen-host
branch
from
a10f414
to
5ebc297
Compare
CendioOssman
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Looks good to me. Nice work @afbjorklund!
And thanks for the help with reviewing, @kalvdans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, for listening only on "localhost"
That is, bind on 127.0.0.1 instead of 0.0.0.0
Closes #1798