Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Cypress builder should act on spec file delete. #1208

Closed
4 tasks done
shlomiassaf opened this issue Mar 26, 2019 · 3 comments
Closed
4 tasks done

[Feature] Cypress builder should act on spec file delete. #1208

shlomiassaf opened this issue Mar 26, 2019 · 3 comments

Comments

@shlomiassaf
Copy link

Please make sure you have read the submission guidelines before posting an issue

Prerequisites

Please answer the following questions for yourself before submitting an issue.
YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed
  • I'm reporting the issue to the correct repository (not related to Angular, AngularCLI or any dependency)

Expected Behavior

When deleting a typescript spec file the target JS file is not deleted.
This will cause the spec file to remain active in the test runner.

When a spec file is deleted the corresponding target file should also be removed.

Current Behavior

The cypress builder delegates everything TS related to the typescript compiler which does not support this feature (microsoft/TypeScript#16057).

This is why I don't think it's a bug but a feature...

Other

If #1207 is implemented, it will require a watcher which can be used also here to watch for spec files that are removed.

This should be an opt-in option, so files are not removed if not specifically instructed to.

@vsavkin
Copy link
Member

vsavkin commented Dec 4, 2019

This has been fixed when we transitioned to using webpack for bundling specs. So I'm going to close this issue. Thank you!

@vsavkin vsavkin closed this as completed Dec 4, 2019
@mightyiam
Copy link

Thank you for following up, @vsavkin.

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants