Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please provide description and summary of a PR when we submit it #29

Open
chrishkchris opened this issue Jun 17, 2020 · 0 comments
Open

Please provide description and summary of a PR when we submit it #29

chrishkchris opened this issue Jun 17, 2020 · 0 comments

Comments

@chrishkchris
Copy link
Contributor

chrishkchris commented Jun 17, 2020 •
edited
Loading

When we submit a PR, please write the summary of the PR and provide the description.

Otherwise, it is difficult for other team members to known what have been done and its effect to our code.

This is an acceptable example of a PR with description
#27

It is also good to provide more details, especially for those PRs which affects the APIs and input output formats
@chrishkchris chrishkchris changed the title Please provide description and summary to the PR when we submit it Please provide description and summary of a PR when we submit it Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrishkchris