Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with Odd and Even week .ics exports #3679

Open
onx001 opened this issue Mar 21, 2024 · 4 comments
Open

Bug with Odd and Even week .ics exports #3679

onx001 opened this issue Mar 21, 2024 · 4 comments

Comments

@onx001
Copy link

onx001 commented Mar 21, 2024

Describe the bug

The ICS exports do not account for recess weeks when calculating odd and even weeks in Google calendar

To Reproduce

Steps to reproduce the behavior:

  1. Add odd/even week slots to timetable
  2. Export timetable as .ics file
  3. Import it on gcal
  4. View slots on ics file after recess weeks
  5. See error in allocating odd/even weeks

Expected behavior

Odd/even week calculation is supposed to exclude the recess week and continue as per normal

Screenshots

image
Here google saves it as weekly

image
Here it double counts after week 11 due to weeks 12 and 13 not being specified

Offending timetable:
https://nusmods.com/timetable/sem-1/share?SC2204=TUT:D1,LEC:1

image
Worsened problems on GCal android

@kokrui
Copy link
Member

kokrui commented Mar 21, 2024

Great catch, and thanks for creating the issue! I can reproduce this

update saturday: nvm, seems to work fine on gcal for me? I feel like I've experienced this before though, but if it works for you too let's close this for now until we figure it out

@onx001
Copy link
Author

onx001 commented Mar 23, 2024

Edit: problem has been refined to a specific case for further review and testing. Appears to be a problem with 1. Defining Odd/Even weeks in website/src/utils/ical.ts
Possible solution: CSV export format for android google calendar users due to weird ics input reformatting with gcal on android.
Update: currently working with modifying ICS export format to be more robust

@Noob-No-1
Copy link

I would like to work on this issue

@Noob-No-1
Copy link

I would like to work on this issue

nvm the issue is alr fixed lmao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants