From a73b481769ad324a89c5678740e51d6597e24fb0 Mon Sep 17 00:00:00 2001 From: Cyrille Bougot Date: Mon, 8 Feb 2021 11:17:47 +0100 Subject: [PATCH] Add missing context help. (PR #12034) * Fixes some missing context help in advanced settings panel. --- source/gui/settingsDialogs.py | 5 +++++ user_docs/en/userGuide.t2t | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/source/gui/settingsDialogs.py b/source/gui/settingsDialogs.py index d28bad112c4..f3216b55b24 100644 --- a/source/gui/settingsDialogs.py +++ b/source/gui/settingsDialogs.py @@ -2478,6 +2478,9 @@ class AdvancedPanelControls( """Holds the actual controls for the Advanced Settings panel, this allows the state of the controls to be more easily managed. """ + + helpId = "AdvancedSettings" + def __init__(self, parent): super().__init__(parent) self._defaultsRestored = False @@ -2581,6 +2584,7 @@ def __init__(self, parent): pgettext("advanced.uiaWithChromium", "No"), ) self.UIAInChromiumCombo = UIAGroup.addLabeledControl(label, wx.Choice, choices=chromiumChoices) + self.bindHelpEvent("ChromiumUIA", self.UIAInChromiumCombo) self.UIAInChromiumCombo.SetSelection(config.conf["UIA"]["allowInChromium"]) self.UIAInChromiumCombo.defaultValue = self._getDefaultValue(["UIA", "allowInChromium"]) @@ -2628,6 +2632,7 @@ def __init__(self, parent): "difflib" ) self.diffAlgoCombo = terminalsGroup.addLabeledControl(diffAlgoComboText, wx.Choice, choices=diffAlgoChoices) + self.bindHelpEvent("DiffAlgo", self.diffAlgoCombo) curChoice = self.diffAlgoVals.index( config.conf['terminals']['diffAlgo'] ) diff --git a/user_docs/en/userGuide.t2t b/user_docs/en/userGuide.t2t index 629292e43d7..ba1579e2b7d 100644 --- a/user_docs/en/userGuide.t2t +++ b/user_docs/en/userGuide.t2t @@ -1857,7 +1857,7 @@ This feature is available and enabled by default on Windows 10 versions 1607 and Warning: with this option enabled, typed characters that do not appear onscreen, such as passwords, will not be suppressed. In untrusted environments, you may temporarily disable [speak typed characters #KeyboardSettingsSpeakTypedCharacters] and [speak typed words #KeyboardSettingsSpeakTypedWords] when entering passwords. -==== Diff algorithm ====[AdvancedSettingsDiffAlgo] +==== Diff algorithm ====[DiffAlgo] This setting controls how NVDA determines the new text to speak in terminals. The diff algorithm combo box has three options: - Automatic: as of NVDA 2021.1, this option is equivalent to Difflib.