Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveText: consider using diff-match-patch #11498

Closed
codeofdusk opened this issue Aug 16, 2020 · 1 comment · Fixed by #11639
Closed

LiveText: consider using diff-match-patch #11498

codeofdusk opened this issue Aug 16, 2020 · 1 comment · Fixed by #11639
Labels
app/windows-terminal New terminal app, potentially supersedes app/windows-console (repo: microsoft/terminal)
Milestone

Comments

@codeofdusk
Copy link
Contributor

codeofdusk commented Aug 16, 2020

Is your feature request related to a problem? Please describe.

Diffing many lines in the console (for example, UI Automation without visible range bounding) reduces performance to the point of unusability (the diffs are comparing lists of 10,000 lines each). This can also be observed in less extreme examples. This long diffing time blocks NVDA.

Describe the solution you'd like

Refactor LiveText to use diff-match-patch instead of difflib. In my limited testing this takes diffing time from well over 30 seconds (I hit CTRL+c) to about a second.

Describe alternatives you've considered

None.

@codeofdusk
Copy link
Contributor Author

Also this would help to fix #3200.

@feerrenrut feerrenrut added the app/windows-terminal New terminal app, potentially supersedes app/windows-console (repo: microsoft/terminal) label Aug 24, 2020
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app/windows-terminal New terminal app, potentially supersedes app/windows-console (repo: microsoft/terminal)
Projects
None yet
3 participants