Update instanceOf to support constructors that have required arguments #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jessidhia
commented
Jun 27, 2019
| instanceOf(RegExp); | ||
|
|
||
| // $ExpectType Decoder<Promise<string>, unknown> | ||
| instanceOf<Promise<string>>(Promise); |
There was a problem hiding this comment.
I originally just used this as an example of a class with a required argument but, because it is generic, the type that shows up on $ExpectType will depend on your TypeScript version.
It actually should be Promise<unknown> in TS 3.6 but for some reason dtslint is seeing it as Promise<{}>; so I gave up and just specified the argument here 🤔
nvie
approved these changes
Jun 27, 2019
|
This is now published as part of v1.15.0 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.