Implicit missing keys in object #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvie
force-pushed
the
implicit-missing-keys-in-object
branch
from
1318779
to
fb4365d
Compare
- When known/allowed field, use implicit-undefined behavior - When unknown field, just pass on whatever there is in the input (i.e. keep explicit-undefined if it's there)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes all decoders from the object family (
object(),exact()andinexact()) return optional fields as implicit-undefined rather than explicit-undefined. This allows spreading the results of these values into an object with default values.Fixes #573.