Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ICY Exoplayer extension by saschpe instead of our janky homemade solution #4

Closed
rocketgarden opened this issue Feb 26, 2019 · 1 comment
Closed

Use ICY Exoplayer extension by saschpe instead of our janky homemade solution #4

rocketgarden opened this issue Feb 26, 2019 · 1 comment
Assignees
@rocketgarden
Labels
tech debt

Comments

@rocketgarden
Copy link
Collaborator

https://github.com/saschpe/android-exoplayer2-ext-icy

This will require migration to Exoplayer v2 in issue #3, and in fact both issues may be interdependent. Should let us delete IcyInputStream and IcyHttpDataSource which are both modified copy/paste classes from ExoPlayer. Hence they are brittle and wildly out of date.
@rocketgarden
Copy link
Collaborator Author

Also this extension has apparently already been approved/integrated into the official extensions list for ExoPlayer
google/ExoPlayer#3735

@rocketgarden rocketgarden self-assigned this Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rocketgarden rocketgarden

Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rocketgarden