Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce has_velocity_dynamics #299

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Introduce has_velocity_dynamics #299

merged 3 commits into from
Aug 20, 2024

Conversation

gwbres
Copy link
Collaborator

@gwbres gwbres commented Aug 15, 2024

  • Simple method to determine whether velocity/dynamics are present, which allows pos_vel() exploitation and helps determine whether full or partial rotation may apply

@gwbres
Introduce has_velocity_dynamics
cf66e00 
   * Simple method to determine whether velocity/dynamics are present,
   which allows pos_vel() exploitation and helps determine whether
   full or partial rotation may apply

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
ChristopherRabotin
ChristopherRabotin reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@ChristopherRabotin ChristopherRabotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! It also makes me think that I need to eventually add the links in the documentation like you did.

anise/src/math/cartesian.rs Outdated Show resolved Hide resolved
gwbres and others added 2 commits August 15, 2024 16:53
@gwbres @ChristopherRabotin
Update anise/src/math/cartesian.rs
decc342 
Co-authored-by: Chris <ChristopherRabotin@users.noreply.github.com>
@gwbres
Update cartesian.rs
68f470b
@ChristopherRabotin
Copy link
Member

The tests fail because of some change I introduced the other day which should specifically prevent this. There's a specific BSP file that is stored in the secrets and only available to me as a maintainer, so I tried to skip the test if that env var isn't available. Obviously that does not work.

@gwbres
Copy link
Collaborator Author

gwbres commented Aug 15, 2024

The tests fail because of some change I introduced the other day

no worries 👍
I'm also thinking maybe this new method should simply be named has_velocity

@ChristopherRabotin
Copy link
Member

I guess what I'm now wondering is whether your application could directly use state.vmag_km_s() > 0.0 directly? I have no strong opinions here.

@ChristopherRabotin ChristopherRabotin merged commit 384b726 into nyx-space:master Aug 20, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherRabotin ChristopherRabotin ChristopherRabotin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwbres @ChristopherRabotin