Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test testLogExtraLogging fails occasionally #483

Open
wrigleyDan opened this issue Jan 31, 2024 · 1 comment
Open

Flaky test testLogExtraLogging fails occasionally #483

wrigleyDan opened this issue Jan 31, 2024 · 1 comment

Comments

@wrigleyDan
Copy link
Contributor

One of the tests in com.o19s.es.ltr.logging.LoggingIT - testLogExtraLogging - fails occasionally.

Running the test multiple times ultimately leads to a successful test run but it would be nice to have a more reliable and predictable test.

com.o19s.es.ltr.logging.LoggingIT > testLogExtraLogging FAILED
    java.lang.AssertionError at LoggingIT.java:626
@wrigleyDan wrigleyDan changed the title Flay test testLogExtraLogging fails occasionally Flaky test testLogExtraLogging fails occasionally Jan 31, 2024
@mkr
Copy link

mkr commented Feb 1, 2024

It's not really clear to me what happens here. It seems to be related to nested hits (or skipping them during logging) as the two other cases with non-nested queries pass reliably. This likely came in 0078300 quite some time ago (cc: @aprudhomme, @nomoa). If there is no other way we might want to remove that code again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants