From 2bc5a34b3ddc527df3502af4a280fc4d2308c030 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ne=C4=8Das?= Date: Tue, 6 Oct 2020 07:43:02 +0200 Subject: [PATCH] ovirt_disk: dont move disk when already in storage_domain (#135) * ovirt_disk: dont move disk when already in storage_domain * add fragment --- changelogs/fragments/ovirt_disk-fix-move.yml | 3 +++ plugins/modules/ovirt_disk.py | 2 ++ 2 files changed, 5 insertions(+) create mode 100644 changelogs/fragments/ovirt_disk-fix-move.yml diff --git a/changelogs/fragments/ovirt_disk-fix-move.yml b/changelogs/fragments/ovirt_disk-fix-move.yml new file mode 100644 index 00000000..8f1c7897 --- /dev/null +++ b/changelogs/fragments/ovirt_disk-fix-move.yml @@ -0,0 +1,3 @@ +--- +bugfixes: + - ovirt_disk - dont move disk when already in storage_domain (https://github.com/oVirt/ovirt-ansible-collection/pull/135) diff --git a/plugins/modules/ovirt_disk.py b/plugins/modules/ovirt_disk.py index 807f1b73..f4208763 100644 --- a/plugins/modules/ovirt_disk.py +++ b/plugins/modules/ovirt_disk.py @@ -606,6 +606,8 @@ def update_storage_domains(self, disk_id): # Initiate move: if self._module.params['storage_domain']: new_disk_storage_id = get_id_by_name(sds_service, self._module.params['storage_domain']) + if new_disk_storage_id in [sd.id for sd in disk.storage_domains]: + return changed changed = self.action( action='move', entity=disk,