-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 5 clarification on NOT operator #85
Comments
@jmgnc Could you please suggest text for the clarification? |
We accepted the clarification that I suggested in the issue. I do not know of any additional clarification, though it is clearly needed as @gtback thinks that their implementation is correct to the spec, though my reading says it is not. I have a request out to him to work w/ me on clarifying the text, and hopefully reopening the issue so that it can be resolved. I'd prefer if most of the discussion can happen in the other issue to keep things contained to one place. |
Most of the debate for this is in oasis-open/cti-pattern-matcher#53 . The issue is still unresolved as we didn't actually make any of the clarification changes in that document. My original suggestion (and it still stands) This text: A Comparison Operator MAY be preceded by the modifier NOT, in which case the resultant Comparison Expression is logically negated. Should be changed to this text. A Comparison Expression MAY be preceded by the modifier NOT, in which case the resultant Comparison Expression is logically negated. Note the difference, it is bold. Also, the text should be moved up to the "Comparison Expression" section, since this is where it now belongs. This text changes this from the allowed syntax (which I don't think was ever the intent)
.. to this
... thus making the syntax much more understandable, and clarifies order of operations. This is a pseudo-breaking change in patterning, but I doubt it will affect anyone in reality because it is changing some esoteric behaviour. |
We talked about this on 2019-06-05 and Jason agreed to add proposed text to the document. |
To be discussed at the 4 Oct meeting. Follow up with implementation evaluation. Errata change or normative change? |
Specification is ambiguous. Add clarity in 2.1.1 and match the grammar and code for STIX python to all say the same thing. |
I have raised an issue w/ the pattern matcher library, and there is probably some clarification that we should add to the spec:
oasis-open/cti-pattern-matcher#53
The text was updated successfully, but these errors were encountered: