Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow leading / in relative artifact location URIs. #480

Closed
ghost opened this issue Sep 28, 2020 · 2 comments
Closed

Don't allow leading / in relative artifact location URIs. #480

ghost opened this issue Sep 28, 2020 · 2 comments
Labels
2.1.0-erratum design-approved The TC approved the design and I can write the change draft impact-documentation-only ready

Comments

@ghost
Copy link

ghost commented Sep 28, 2020

The rationale for requiring artifactLocation.uri to be a relative reference when uriBaseId is present is that we should be able to combine uri with any file-based URI to form an absolute path. /dir/file.c is technically a relative URI reference, but it is an absolute file path. That means you cannot combine it with a base value such as file:///C:/dev/myProject.

The spec should prohibit leading /s on artifactLocation.uri. It doesn't even matter whether or not artifactLocation.uriBaseId is present: if artifactLocation.uri is not absolute, it can't start with a /.

@michaelcfanning FYI

@michaelcfanning
Copy link
Contributor

Approved TC session 43.

@michaelcfanning michaelcfanning changed the title Don't allow leading / in relative artifact location URIs Don't allow leading / in relative artifact location URIs. Nov 8, 2021
@dmk42
Copy link
Contributor

dmk42 commented Dec 19, 2023

Now that the Errata document has been published, this has been fixed in the official version of the standard.

@dmk42 dmk42 closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.0-erratum design-approved The TC approved the design and I can write the change draft impact-documentation-only ready
Projects
None yet
Development

No branches or pull requests

2 participants