Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop oclif-CLI with an error when node version is not supported #1197

Open
tram98 opened this issue Sep 20, 2024 · 2 comments · May be fixed by #1198
Open

Stop oclif-CLI with an error when node version is not supported #1197

tram98 opened this issue Sep 20, 2024 · 2 comments · May be fixed by #1198
Labels
enhancement New feature or request

Comments

@tram98
Copy link

tram98 commented Sep 20, 2024

Is your feature request related to a problem? Please describe.
I installed the CLI globally using bun. I did not get an error during installation.
When I ran the app, I got an error TypeError: shellPath.at is not a function.
I noticed that I was running node 14 in my path, which is not supported.

Describe the solution you'd like
I suggest checking node's version at startup and fail with an error if the version is not supported.

Describe alternatives you've considered
N/A

Additional context
N/A

@tram98 tram98 changed the title Stop oclif-CLI with an error when node version is not satisfied Stop oclif-CLI with an error when node version is not supported Sep 20, 2024
@mdonnalley
Copy link
Contributor

We had a check for this at one point in time but removed it because we thought it was unnecessary since npm install will fail when the engine property isn't satisfied.

I'm not super familiar with bun but it seems that bun install doesn't check the node engine property on install

@mdonnalley mdonnalley added needs response enhancement New feature or request and removed needs response labels Sep 20, 2024
Copy link

git2gus bot commented Sep 20, 2024

This issue has been linked to a new work item: W-16795546

@mdonnalley mdonnalley linked a pull request Sep 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants