Retrieving events throws Stack.Overflow exception.

[bobbytreed]

In the lastest local build (0.33.0), I still get a StackOverflow Exception. While the type has been updated, something in PocoSerializationStrategy is still trying to convert to Int32
System.AggregateException: One or more errors occurred. ---> System.OverflowException: Value was either too large or too small for an Int32.
at System.Convert.ToInt32(Int64 value)
at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider)
at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type)
at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type)
at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type)
at Octokit.SimpleJson.DeserializeObject[T](String json, IJsonSerializerStrategy jsonSerializerStrategy)
at Octokit.Internal.JsonHttpPipeline.DeserializeResponse[T](IResponse response)
at Octokit.Connection.d__571.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Octokit.ApiConnection.<GetPage>d__421.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Octokit.ApiConnection.<>c__DisplayClass17_01.<<GetAll>b__0>d.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Octokit.ApiPagination.<GetAllPages>d__01.MoveNext()
--- End of inner exception stack trace ---
---> (Inner Exception #0) System.OverflowException: Value was either too large or too small for an Int32.
at System.Convert.ToInt32(Int64 value)
at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider)
at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type)
at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type)
at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type)
at Octokit.SimpleJson.DeserializeObject[T](String json, IJsonSerializerStrategy jsonSerializerStrategy)
at Octokit.Internal.JsonHttpPipeline.DeserializeResponse[T](IResponse response)
at Octokit.Connection.d__571.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Octokit.ApiConnection.<GetPage>d__421.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Octokit.ApiConnection.<>c__DisplayClass17_01.<<GetAll>b__0>d.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Octokit.ApiPagination.<GetAllPages>d__01.MoveNext()<---

[ryangribble]

It could be another field that needs to change from int to long

Are you able to post a code snippet that reproduces it on a public repository?

[ryangribble]

It could be another field that needs to change from int to long

Are you able to post a code snippet that reproduces it on a public repository?

[bobbytreed]

I was just creating a github client in powershell and trying to query all events for a repo.

As for the code, I didnt change it. I built directly from the cloned repo.

I'll admit maybe I did something wrong, but I really can't guess what.

[shiftkey]

I was just creating a github client in powershell and trying to query all events for a repo.

@bobbytreed if you can reproduce this against a public repository and can share that with us it'll help us to reproduce the issue on our end and identify what field returned from the API now overflows int.

[bobbytreed]

I fixed it locally by changing IssueEvent ID to a long as well. I still hit an issue though with pagination.

Exception : System.AggregateException: One or more errors occurred. ---> Octokit.ApiValidationException: In order to
keep the API fast for everyone, pagination is limited for this resource. Check the rel=last link relation
in the Link response header to see how far back you can traverse.
at Octokit.Connection.HandleErrors(IResponse response)

[shiftkey]

@bobbytreed some sample code would still be handy so we can understand how you're encountering issues

[bobbytreed]

$inmem = new-object OctoKit.Internal.InMemoryCredentialStore -ArgumentList ($cred)
$header = New-Object octokit.productheadervalue -ArgumentList "azure-function"
New-Variable -Name gitHubClient -Scope Global -Option AllScope -Force -Value $(new-object octokit.githubclient -ArgumentList $header, $inmem)
$options = New-Object octokit.apioptions
$options.pagesize = 100
$events = $gitHubClient.Issue.Events.GetAllForRepository("","", $options)

[shiftkey]

@bobbytreed apologies for the delay. I see that this last line doesn't have the owner and repo values:

$events = $gitHubClient.Issue.Events.GetAllForRepository("","", $options)

If this is reproducible on a public repository that'll greatly help to speed up reproducing this issue.

[hnrkndrssn]

If this is reproducible on a public repository that'll greatly help to speed up reproducing this issue.

This will should do it $events = $gitHubClient.Issue.Events.GetAllForRepository("OctopusDeploy", "Issues", $options)

[mynkow]

This fails for me with the following exception:

System.OverflowException: 'Value was either too large or too small for an Int32.'

NOTE: I guess mine is a different issue...

[shiftkey]

This feels very similar to #2031, and while we have a PR started in #2037 this appears to have stalled. Gonna leave these both open for now and re-test the fix to confirm both issues are resolved.

[mijacobs]

This feels very similar to #2031, and while we have a PR started in #2037 this appears to have stalled. Gonna leave these both open for now and re-test the fix to confirm both issues are resolved.

Any update on this? It looks like the PR still hasn't gone through.

[shiftkey]

@mijacobs it turns out that #2060 doesn't fix this, but #2092 will

[bifacil]

Any update on this?

The bug exists on latest version (9.1.2)

Inner Exception (System.OverflowException): Value was either too large or too small for an Int32.
at System.Convert.ThrowInt32OverflowException()
at System.Convert.ToInt32(Int64 value)
at System.Int64.System.IConvertible.ToInt32(IFormatProvider provider)
at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider)
at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) in //Octokit/SimpleJson.cs:line 1437
at Octokit.Internal.SimpleJsonSerializer.GitHubSerializerStrategy.DeserializeObject(Object value, Type type) in //Octokit/Http/SimpleJsonSerializer.cs:line 183
at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) in //Octokit/SimpleJson.cs:line 1492
at Octokit.Internal.SimpleJsonSerializer.GitHubSerializerStrategy.DeserializeObject(Object value, Type type) in //Octokit/Http/SimpleJsonSerializer.cs:line 183
at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) in //Octokit/SimpleJson.cs:line 1519
at Octokit.Internal.SimpleJsonSerializer.GitHubSerializerStrategy.DeserializeObject(Object value, Type type) in //Octokit/Http/SimpleJsonSerializer.cs:line 183
at Octokit.SimpleJson.DeserializeObject(String json, Type type, IJsonSerializerStrategy jsonSerializerStrategy) in //Octokit/SimpleJson.cs:line 584
at Octokit.SimpleJson.DeserializeObject[T](String json, IJsonSerializerStrategy jsonSerializerStrategy) in //Octokit/SimpleJson.cs:line 596
at Octokit.Internal.SimpleJsonSerializer.Deserialize[T](String json) in //Octokit/Http/SimpleJsonSerializer.cs:line 22
at Octokit.Internal.JsonHttpPipeline.DeserializeResponse[T](IResponse response) in //Octokit/Http/JsonHttpPipeline.cs:line 60
at Octokit.Connection.Run[T](IRequest request, CancellationToken cancellationToken, Func2 preprocessResponseBody) in /_/Octokit/Http/Connection.cs:line 753 at Octokit.ApiConnection.GetPage[TU](Uri uri, IDictionary2 parameters, String accepts, ApiOptions options, Func2 preprocessResponseBody) in /_/Octokit/Http/ApiConnection.cs:line 695 at Octokit.ApiConnection.<>c__DisplayClass20_01.<b__0>d.MoveNext() in /_/Octokit/Http/ApiConnection.cs:line 240
--- End of stack trace from previous location ---
at Octokit.ApiPagination.GetAllPages[T](Func`1 getFirstPage, Uri uri)

[bifacil]

Some property need to be changed from int to long...

[bifacil]

Same issue here: #2889

[maddada]

Facing the same issue all of a sudden, any solutions?

"Value was either too large or too small for an Int32."

at System.Convert.ToInt32(Int64 value) at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider) at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) at Octokit.SimpleJson.DeserializeObject[T](String json, IJsonSerializerStrategy jsonSerializerStrategy) at Octokit.Internal.JsonHttpPipeline.DeserializeResponse[T](IResponse response) at Octokit.Connection.<Run>d__67'1.MoveNext() at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Octokit.ApiConnection.<Get>d__8'1.MoveNext() at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter'1.GetResult() at LicenseManager.Controllers.Api.GithubReportsController.<GetPullRequestsReport>d__1.MoveNext() in <MyProjectName>\Controllers\Api\GithubReportsController.cs:line 79

[bifacil]

Facing the same issue all of a sudden, any solutions?

"Value was either too large or too small for an Int32."

at System.Convert.ToInt32(Int64 value) at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider) at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) at Octokit.SimpleJson.DeserializeObject[T](String json, IJsonSerializerStrategy jsonSerializerStrategy) at Octokit.Internal.JsonHttpPipeline.DeserializeResponse[T](IResponse response) at Octokit.Connection.<Run>d__67'1.MoveNext() at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Octokit.ApiConnection.<Get>d__8'1.MoveNext() at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter'1.GetResult() at LicenseManager.Controllers.Api.GithubReportsController.<GetPullRequestsReport>d__1.MoveNext() in <MyProjectName>\Controllers\Api\GithubReportsController.cs:line 79

Update top 10.0.

It's solved.

#2889