Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Fix ActionsSelfHostedRunnersClient Delete calls #2739

Closed
1 task done
lineville opened this issue Jun 30, 2023 · 0 comments · Fixed by #2740
Closed
1 task done

[BUG]: Fix ActionsSelfHostedRunnersClient Delete calls #2739

lineville opened this issue Jun 30, 2023 · 0 comments · Fixed by #2740
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@lineville
Copy link
Contributor

What happened?

Calling ActionsSelfHostedRunnersClient.DeleteEnterpriseRunner, ActionsSelfHostedRunnersClient.DeleteOrganizationRunner, ActionsSelfHostedRunnersClient.DeleteRepositoryRunner throw exceptions with the following message: The value cannot be null or empty. (Parameter 'mediaType').

The source of this error is that ApiOptions are being passed in to the delete methods which don't expect this kind of object. They expect a request body type, but for these calls we can actually just omit this argument altogether. I have a fix for this that I've tested.

Versions

Octokit.net 6.2.1

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lineville lineville added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant