-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrongly encoded ref
parameter
#73
Comments
Sorry for the unintended change in behavior. The new behavior is actually correct, but I was not aware that URL parameters were not encoded until a recent dependency update. See also #71 Right now both your links return 404 for me
I was able to reproduce the problem with the
The problem in this case is the route. Instead of - GET /repos/{owner}/{repo}/git/{ref}
+ GET /repos/{owner}/{repo}/git/ref/{ref} Then remove the The |
Fantastic, thank you very much @gr2m. I'll update our CI with the route that you've suggested. |
In https://github.com/opencollective/opencollective-frontend/blob/1eab647efdf0d953c1675d076273b177d4a38180/.github/workflows/e2e.yml#L90, we use
request-action
to fetch the matching branch on remote repository (GET /repos/{owner}/{repo}/git/{ref}
).This used to generate a valid URL like https://api.github.com/repos/opencollective/opencollective-frontend/git/refs/heads/debt/remove-guest-tokens, but since a few days we're getting an encoded version of the parameter instead, which results in the branch appearing as missing: https://api.github.com/repos/opencollective/opencollective-frontend/git/refs%2Fheads%2Fdebt%2Fremove-guest-tokens.
Maybe that's similar to #71?
Is there a way to tell
request-action
to not URL encode a parameter?Full debug log:
The text was updated successfully, but these errors were encountered: