Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Error TS2345 started appearing after upgrading from 19.0.6 to 19.0.7(latest) #289

Closed
1 task done
aramovic79 opened this issue Apr 26, 2023 · 4 comments
Closed
1 task done
Labels
Duplicate There are other issues and PRs like this Type: Bug Something isn't working as documented

Comments

@aramovic79
Copy link

aramovic79 commented Apr 26, 2023

What happened?

After upgrading @octokit/rest to the latest one, this TS2345 error started appearing:

Error TS2345: Argument of type '{ body: string; issue_number: number; owner: string; repo: string; }' is not assignable to parameter of type 'RequestParameters & Omit<{ owner: string; repo: string; issue_number: number; } & { data: never; }, "baseUrl" | "headers" | "mediaType">'

cc: @gr2m, @wolfy1339

Versions

Node v14.21.1 typescript@4.9.5 @octokit/rest@19.0.7

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aramovic79 aramovic79 added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Apr 26, 2023
@wolfy1339
Copy link
Member

Can you share the version of @octokit/types that is installed?

I think this could be related to an issue in that package. octokit/types.ts#528

@aramovic79
Copy link
Author

Can you share the version of @octokit/types that is installed?

I think this could be related to an issue in that package. octokit/types.ts#528

Version is 9.1.2
As you spotted well - the issue is caused by the code here: @octokit/types/dist-types/generated/Endpoints.d.ts:14
What would be your proposal? We've for now downgraded version to the previous one.

@wolfy1339
Copy link
Member

For now downgrading is the only way to avoid this, until my fix gets landed

@wolfy1339 wolfy1339 added Duplicate There are other issues and PRs like this and removed Status: Triage This is being looked at and prioritized labels Apr 26, 2023
@wolfy1339
Copy link
Member

wolfy1339 commented Apr 26, 2023

Closing as octokit/types.ts#528 tracks this already

@wolfy1339 wolfy1339 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate There are other issues and PRs like this Type: Bug Something isn't working as documented
Projects
Archived in project
Development

No branches or pull requests

2 participants