Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Figure Of Merits #1017

Closed
zickert opened this issue Jun 1, 2017 · 3 comments
Closed

Add Figure Of Merits #1017

zickert opened this issue Jun 1, 2017 · 3 comments

Comments

@zickert
Copy link
Contributor

zickert commented Jun 1, 2017

Add implementation of figure of merits to quantitatively compare reconstructions with known ground truth. Separate branch with corresponding pull request in preparation.

@adler-j
Copy link
Member

adler-j commented Jun 4, 2017

A general comment is that if we make a odl.contrib.fom package (which i think we should) then there are some sub-modules that should be kept separate (in my opinion). Some suggested such sub-modules would be (names are obviously preliminary):

  • unsupervised: FOMs of the form fom(reconstruction) attempting to estimate features from a single image.
  • supervised: FOMs of the form fom(reconstruction, true) computing some generalized distance
  • ensamble: FOMs of the form fom(reconstruction1, reconstruction2, ..., reconstructionn, [true]) computing some kind of batch statistic (e.g. noise sensitivity, etc)

@adler-j
Copy link
Member

adler-j commented Jun 8, 2017

I was thinking about this when implementing some other stuff and I realized that there are some features that would be nice to have. These do NOT need to be implemented in the PR, but should be added shortly after.

  • More FOM, in particular we want "signal to noise ratio" (SNR) and "peak signal to noise ratio" (PSNR)
  • Utilities to normalize values, either as a parameter to the FOMs (e.g. normalization=...) or by external functions. Examples include z-scores and rescaling into [0, 1].
  • Unsupervised FOMs, in particular some type of noise estimation similar to this one

Anyway, would be great to get the main skeleton in so we can start building on top of it.

@adler-j
Copy link
Member

adler-j commented Jul 10, 2017

Closed by #1018

@adler-j adler-j closed this as completed Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants