fix: failed to search items by rss feed url which has query parameters #4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sywhb
commented
Aug 23, 2024
sywhb
commented
- encode uri component of the rss feed url
- use descriminated unions to differetiate rss and newsletter subscription
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jacksonh
reviewed
Aug 23, 2024
| if (useFolders) { | ||
| const param = `folder_${parameters.length}` | ||
| const folderSql = escapeQueryWithParameters( | ||
| `library_item.folder = :${param}`, | ||
| { [param]: value } | ||
| ) | ||
| sql = `(${sql} AND ${folderSql})` | ||
| return `(library_item.archived_at IS NULL AND ${folderSql})` |
There was a problem hiding this comment.
Did you want these changes in this PR too?
There was a problem hiding this comment.
Thanks! I will move these backend changes to a separate PR
* encode uri component of the rss feed url * use descriminated unions to differetiate rss and newsletter subscription
This reverts commit b2cf7d2.
sywhb
force-pushed
the
fix/search-by-rss-feed-url
branch
from
bd58161
to
bb9967a
Compare
jacksonh
reviewed
Aug 26, 2024
| @@ -266,7 +271,11 @@ export default function Rss(): JSX.Element { | |||
| </VStack> | |||
| } | |||
| onClick={() => { | |||
| router.push(`/home?q=in:inbox rss:"${subscription.url}"`) | |||
| router.push( | |||
| `/home?q=in:inbox rss:"${encodeURIComponent( | |||
There was a problem hiding this comment.
Actually this should be search?q=
jacksonh
approved these changes
Aug 26, 2024
|
Just one small change as we don't use home for queries anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.