Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ktunnel --tls should set traefik.ingress.kubernetes.io/service.serversscheme: https annotation #69

Open
erulabs opened this issue Jan 5, 2022 · 1 comment

Comments

@erulabs
Copy link

erulabs commented Jan 5, 2022

Hello!

I've been loving ktunnel, and just started using it with a cluster that uses Traefik. I spent a full 3 hours trying to figure out how to get the Ingress system to pass HTTPS thru my ktunnel service, and finally found out that the service needs to have an annotation that hints to Traefik that the service speaks TLS.

When using --tls option, the service should be created with the traefik.ingress.kubernetes.io/service.serversscheme: https annotation, which would make Traefik ingresses pointing at the service work properly.

Honestly, this seems more like a failure on Traefik's side, but since adding an annotation is a harmless and very light change, it seems like a nice convenience that ktunnel could add.

Feel free to close this if you don't think ktunnel should deal with this - I have mixed feelings. It's not "correct", but it certainly would have saved me a lot of time.

@omrikiei
Copy link
Owner

omrikiei commented Jan 7, 2022

How about if we add a flag that can be used to set a custom flag to the manifests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants