XUnit test parallel execution

[smyrman]

To quote the documentation:

Gomega uses a global (singleton) fail handler. This has the benefit that you don’t need to pass the fail handler down to each test, but does mean that you cannot run your XUnit style tests in parallel with Gomega. If you find this odious, open an issue on Github and let me know.

Gomega appears to be a pretty decent matcher library, but it would be nice to get better parallel execution support when using XUnit tests, e.g. allowing the initialization of a handler instance:

 m := gomega.NewTHandler(t)
 m.Expect(something).To(gomega.BeNil())

[rosenhouse]

Yes please. I would really like to use Gomega in a project that has XUnit-style tests, but I'm hesitant to introduce it, since it cannot be used in parallel tests.

[onsi]

I just pushed a change to master that fixes this and updated the docs. Assuming a . import you can now:

g := NewGomegaWithT(t)
g.Expect(foo).To(BeNil())
g.Eventually(foo).Should(Equal("bar"))
g.Consistently(foo).Should(Equal("bar"))

[rosenhouse]

This works great, thank you!

[onsi]

Great thanks! @smyrman wdyt?

[rosenhouse]

Just remember to (re-) initialize your g inside any subtests, e.g.

func TestConfigLoadMissingRequiredFields(t *testing.T) {
	requiredFieldNames := []string{
		"ServerCACertPath",
		"ClientCertPath",
		"ClientKeyPath",
		"Address",
		"PollInterval",
	}
	for _, n := range requiredFieldNames {
		fieldName := n // don't close over the iterator
		t.Run("required field "+fieldName, func(t *testing.T) {
			g := gomega.NewGomegaWithT(t)
...

[smyrman]

@onsi, this looks like the right interface to me - looking forward to test it after the holidays 👍

[rosenhouse]

@onsi any chance you could cut a release with this commit? the downstream project I'm contributing to prefers that their dependencies be referenced by tag name. thanks!

[williammartin]

@onsi Please loop me in if you do ^

Also, I couldn't find the documentation referenced in the issue, just want to make sure everything got updated as necessary.

[onsi]

can do - but can't get to it till tonight at the earliest. I'll write up instructions for how to do it and commit them as well that way other committers can own this, too and we can iterate on it

[zachgersh]

hey @williammartin - I think it is probably safe to close this now?

[rosenhouse]

Yes, this issue is fixed.

[williammartin]

Sweeeeet. Thanks all.