Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Login & Register views design #130

Closed
Tracked by #14 ...
Bilelkihal opened this issue Dec 14, 2022 · 5 comments · Fixed by #142 or #144
Closed
Tracked by #14 ...

Update Login & Register views design #130

Bilelkihal opened this issue Dec 14, 2022 · 5 comments · Fixed by #142 or #144
Assignees
Labels
enhancement New feature or request

Comments

@Bilelkihal
Copy link
Collaborator

Bilelkihal commented Dec 14, 2022

Why should we update the existing views:

  • The old interface has bad styling and does not keep pace with modern website designs.

Decisions I made in the new design that need to be approved:

  • Replace "Account name" by "User name" (Because it is the most used in different websites).
  • Add registration and login directly using Google and GitHub (make the process much easier for users, users do not like to remember a lot of passwords, more secure, the internet is going passwordless in the next years).
  • Real-time user error correction in registration (Ex: Tell the user that the username is already in use, or that the password is weak the time he's typing).

Check the new design & leave me comments in Figma:
https://www.figma.com/file/n2tOIfgVlVvFAr3F00Ab5m/Ontoportal-alliance?node-id=9%3A19&t=BhpXNbL45EpcQHv2-1

@syphax-bouazzouni
Copy link
Collaborator

I added comments to your figma (is the link public ?), good work 👍

@Bilelkihal
Copy link
Collaborator Author

I've replied to your comments in Figma.
Yeah, anyone with the link can view it,
do I make it private?

@syphax-bouazzouni
Copy link
Collaborator

@jonquet Can you review and validate the Figma mockup so that we can start implementation

@jonquet
Copy link

jonquet commented Dec 16, 2022

Figma mockups looks great. Just made 2 comments.

Is the integration with Google / GitHub login easy to do? This would be a great addition.
See also: agroportal/project-management#341
(i.e., even if a user do not select login via GitHub, it woudl be good to ask them their ids on GitHub and ORCID)

Ready to start implementing.

@syphax-bouazzouni
Copy link
Collaborator

Done in #142 and #144

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants