From d9ff9dc7bc0109bbc89c6f861f487e55360534c9 Mon Sep 17 00:00:00 2001 From: Benjamin Lorenz Date: Wed, 14 Feb 2024 08:43:02 +0100 Subject: [PATCH] remove deprecations from 0.14.0 and before (#3358) * remove deprecations from 0.14.0 and before * remove more old deprecations these functions were deprecated in #2980 (long before 0.14.0) but slightly in the wrong location in the file * re-add ne and nv alias * remove obsolete exports * fix deprecated usage of MPolyQuoLocalizedRing -> MPolyQuoLocRing * add explanation for ne and nv --- src/Rings/mpolyquo-localizations.jl | 6 +- src/aliases.jl | 4 + src/deprecations.jl | 610 ---------------------------- src/exports.jl | 3 - 4 files changed, 7 insertions(+), 616 deletions(-) diff --git a/src/Rings/mpolyquo-localizations.jl b/src/Rings/mpolyquo-localizations.jl index 9a1217bc6f40..5b18423b69bf 100644 --- a/src/Rings/mpolyquo-localizations.jl +++ b/src/Rings/mpolyquo-localizations.jl @@ -2352,7 +2352,7 @@ function is_isomorphism( end function _as_localized_quotient(R::MPolyRing) - result = MPolyQuoLocalizedRing(R, ideal(R, elem_type(R)[]), powers_of_element(one(R))) + result = MPolyQuoLocRing(R, ideal(R, elem_type(R)[]), powers_of_element(one(R))) iso = hom(R, result, gens(result), check=false) iso_inv = hom(result, R, gens(R), check=false) return result, iso, iso_inv @@ -2360,7 +2360,7 @@ end function _as_localized_quotient(A::MPolyQuoRing) R = base_ring(A) - result = MPolyQuoLocalizedRing(R, modulus(A), powers_of_element(one(R))) + result = MPolyQuoLocRing(R, modulus(A), powers_of_element(one(R))) iso = hom(A, result, gens(result), check=false) iso_inv = hom(result, A, gens(R), check=false) return result, iso, iso_inv @@ -2368,7 +2368,7 @@ end function _as_localized_quotient(L::MPolyLocRing) R = base_ring(L) - result = MPolyQuoLocalizedRing(R, ideal(R, elem_type(R)[]), inverted_set(L)) + result = MPolyQuoLocRing(R, ideal(R, elem_type(R)[]), inverted_set(L)) iso = hom(L, result, gens(result), check=false) iso_inv = hom(result, L, gens(R), check=false) return result, iso, iso_inv diff --git a/src/aliases.jl b/src/aliases.jl index d56072a4ef02..d6bd06211242 100644 --- a/src/aliases.jl +++ b/src/aliases.jl @@ -55,3 +55,7 @@ function number_of_vertices end @alias nroots number_of_roots @alias nsimpleroots number_of_simple_roots @alias nvertices number_of_vertices + +# these are kept for compatibility with Graphs.jl / GraphsBase.jl +@alias ne number_of_edges +@alias nv number_of_vertices diff --git a/src/deprecations.jl b/src/deprecations.jl index 161dad072ba9..53d2e4fff8f6 100644 --- a/src/deprecations.jl +++ b/src/deprecations.jl @@ -1,527 +1,3 @@ -# Deprecated in 0.10.* -@deprecate automorphisms(x::Graph) automorphism_group_generators(x) - -# Deprecated after 0.11.3 -@deprecate is_finite_order(x::GAPGroupElem) is_finiteorder(x) -@deprecate elements(C::GroupConjClass) collect(C) -@deprecate conjugate_subgroup(G::GAPGroup, x::GAPGroupElem) conjugate_group(G, x) -@deprecate gap_perm(L::AbstractVector{<:IntegerUnion}) perm(L::AbstractVector{<:IntegerUnion}) -@deprecate elements(C::GroupCoset) collect(C) -@deprecate elements(C::GroupDoubleCoset) collect(C) -@deprecate map_from_character_to_principal_divisors(v::NormalToricVarietyType) map_from_character_lattice_to_torusinvariant_weil_divisor_group(v) -@deprecate map_from_weil_divisors_to_class_group(v::NormalToricVarietyType) map_from_torusinvariant_weil_divisor_group_to_class_group(v) -@deprecate map_from_cartier_divisor_group_to_torusinvariant_divisor_group(v::NormalToricVarietyType) map_from_torusinvariant_cartier_divisor_group_to_torusinvariant_weil_divisor_group(v) -@deprecate map_from_cartier_divisor_group_to_picard_group(v::NormalToricVarietyType) map_from_torusinvariant_cartier_divisor_group_to_picard_group(v) -@deprecate cartier_divisor_group(v::NormalToricVarietyType) torusinvariant_cartier_divisor_group(v) -@deprecate torusinvariant_divisor_group(v::NormalToricVarietyType) torusinvariant_weil_divisor_group(v) -@deprecate StructureSheaf(v::NormalToricVarietyType) structure_sheaf -@deprecate morphism_on_cartier_divisor_group(tm::ToricMorphism) morphism_on_torusinvariant_cartier_divisor_group(tm) -@deprecate bounded(Obj::Polyhedron) is_bounded(Obj) -@deprecate vf_group(P::Polyhedron) automorphism_group(P; action = :on_facets) -@deprecate birkhoff(n::Integer; even::Bool = false) birkhoff_polytope(n; even=even) -@deprecate cross(args...) cross_polytope(args...) -@deprecate gelfand_tsetlin(lambda::AbstractVector) gelfand_tsetlin_polytope(lambda) - - -# Deprecated after 0.11.4 -function AffineNormalToricVariety(C::Cone; set_attributes::Bool = true) - Base.depwarn("'AffineNormalToricVariety(C::Cone; set_attributes::Bool = true)' is deprecated, use "* - "'affine_normal_toric_variety(C::Cone; set_attributes::Bool = true)' instead.", :AffineNormalToricVariety) - affine_normal_toric_variety(C) -end - -function AffineNormalToricVariety(v::NormalToricVariety; set_attributes::Bool = true) - Base.depwarn("'AffineNormalToricVariety(v::NormalToricVariety; set_attributes::Bool = true)' is deprecated, use "* - "'affine_normal_toric_variety(v::NormalToricVariety; set_attributes::Bool = true)' instead.", :AffineNormalToricVariety) - affine_normal_toric_variety(v) -end - -function NormalToricVariety(C::Cone; set_attributes::Bool = true) - Base.depwarn("'NormalToricVariety(C::Cone; set_attributes::Bool = true)' is deprecated, use "* - "'normal_toric_variety(C::Cone; set_attributes::Bool = true)' instead.", :NormalToricVariety) - normal_toric_variety(C) -end - -function NormalToricVariety(rays::Vector{Vector{Int64}}, max_cones::Vector{Vector{Int64}}; non_redundant::Bool = false, set_attributes::Bool = true) - Base.depwarn("'NormalToricVariety(rays::Vector{Vector{Int64}}, max_cones::Vector{Vector{Int64}}; "* - "non_redundant::Bool = false, set_attributes::Bool = true)' is deprecated, use "* - "'normal_toric_variety(rays::Vector{Vector{Int64}}, max_cones::Vector{Vector{Int64}}; "* - "non_redundant::Bool = false, set_attributes::Bool = true)' instead.", :NormalToricVariety) - normal_toric_variety(rays, max_cones; non_redundant = non_redundant) -end - -function NormalToricVariety(PF::PolyhedralFan; set_attributes::Bool = true) - Base.depwarn("'NormalToricVariety(PF::PolyhedralFan; set_attributes::Bool = true)' is deprecated, use"* - "'normal_toric_variety(PF::PolyhedralFan)' instead.", :NormalToricVariety) - normal_toric_variety(PF) -end - -function NormalToricVariety(P::Polyhedron; set_attributes::Bool = true) - Base.depwarn("'NormalToricVariety(P::Polyhedron; set_attributes::Bool = true)' is deprecated, use"* - "'normal_toric_variety(P::Polyhedron; set_attributes::Bool = true)' instead.", :NormalToricVariety) - normal_toric_variety(P) -end - -@deprecate NormalToricVarietiesFromStarTriangulations(P::Polyhedron; set_attributes::Bool = true) normal_toric_varieties_from_star_triangulations(P) -@deprecate NormalToricVarietyFromGLSM(charges::ZZMatrix; set_attributes::Bool = true) normal_toric_varieties_from_glsm(charges) - -function RationalEquivalenceClass(v::NormalToricVarietyType, coefficients::Vector{T}) where {T <: IntegerUnion} - Base.depwarn("'RationalEquivalenceClass(v::NormalToricVarietyType, coefficients::Vector{T}) where {T <: IntegerUnion}'"* - " is deprecated, use 'rational_equivalence_class(v::NormalToricVarietyType, coefficients::Vector{T}) "* - "where {T <: IntegerUnion}' instead.", RationalEquivalenceClass) - rational_equivalence_class(v, coefficients) -end - -function RationalEquivalenceClass(d::ToricDivisor) - Base.depwarn("'RationalEquivalenceClass(d::ToricDivisor)' is deprecated, use "* - "'rational_equivalence_class(d::ToricDivisor)' instead.", :RationalEquivalenceClass) - rational_equivalence_class(d) -end - -function RationalEquivalenceClass(c::ToricDivisorClass) - Base.depwarn("'RationalEquivalenceClass(c::ToricDivisorClass)' is deprecated, use "* - "'rational_equivalence_class(c::ToricDivisorClass)' instead.", :RationalEquivalenceClass) - rational_equivalence_class(c) -end - -function RationalEquivalenceClass(l::ToricLineBundle) - Base.depwarn("'RationalEquivalenceClass(l::ToricLineBundle)' is deprecated, use "* - "'rational_equivalence_class(l::ToricLineBundle)' instead.", :RationalEquivalenceClass) - rational_equivalence_class(l) -end - -function RationalEquivalenceClass(cc::CohomologyClass) - Base.depwarn("'RationalEquivalenceClass(cc::CohomologyClass)' is deprecated, use "* - "'rational_equivalence_class(cc::CohomologyClass)' instead.", :RationalEquivalenceClass) - rational_equivalence_class(cc) -end - -function RationalEquivalenceClass(sv::ClosedSubvarietyOfToricVariety) - Base.depwarn("'RationalEquivalenceClass(sv::ClosedSubvarietyOfToricVariety)' is deprecated, use "* - "'rational_equivalence_class(sv::ClosedSubvarietyOfToricVariety)' instead.", :RationalEquivalenceClass) - rational_equivalence_class(sv) -end - -function CohomologyClass(d::ToricDivisor) - Base.depwarn("'CohomologyClass(d::ToricDivisor)' is deprecated, use "* - "'cohomology_class(d::ToricDivisor)' instead.", :CohomologyClass) - cohomology_class(d) -end - -function CohomologyClass(c::ToricDivisorClass) - Base.depwarn("'CohomologyClass(c::ToricDivisorClass)' is deprecated, use "* - "'cohomology_class(c::ToricDivisorClass)' instead.", :CohomologyClass) - cohomology_class(c) -end - -function CohomologyClass(l::ToricLineBundle) - Base.depwarn("'CohomologyClass(l::ToricLineBundle)' is deprecated, use "* - "'cohomology_class(l::ToricLineBundle)' instead.", :CohomologyClass) - cohomology_class(l) -end - -function CyclicQuotientSingularity(n::T, q::T) where {T <: IntegerUnion} - Base.depwarn("'CyclicQuotientSingularity(n::ZZRingElem, q::ZZRingElem)' is deprecated, use "* - "'cyclic_quotient_singularity(n::ZZRingElem, q::ZZRingElem)' instead.", :CyclicQuotientSingularity) - cyclic_quotient_singularity(n, q) -end - -function ClosedSubvarietyOfToricVariety(toric_variety::NormalToricVarietyType, defining_polynomials::Vector{MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}}) - Base.depwarn("ClosedSubvarietyOfToricVariety(toric_variety::NormalToricVarietyType, "* - "defining_polynomials::Vector{MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}}) is deprecated, use "* - "'closed_subvariety_of_toric_variety(toric_variety::NormalToricVarietyType, "* - "defining_polynomials::Vector{MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}})' instead.", :ClosedSubvarietyOfToricVariety) - closed_subvariety_of_toric_variety(toric_variety, defining_polynomials) -end - -function ToricDivisor(v::NormalToricVarietyType, coeffs::Vector{T}) where {T <: IntegerUnion} - Base.depwarn("'ToricDivisor(v::NormalToricVarietyType, coeffs::Vector{T}) where {T <: IntegerUnion}' "* - "is deprecated, use 'toric_divisor(v::NormalToricVarietyType, coeffs::Vector{T}) "* - "where {T <: IntegerUnion}' instead.", :ToricDivisor) - toric_divisor(v, coeffs) -end - -@deprecate DivisorOfCharacter(v::NormalToricVarietyType, character::Vector{T}) where {T <: IntegerUnion} divisor_of_character(v, character) - -function ToricDivisorClass(v::NormalToricVarietyType, coeffs::Vector{T}) where {T <: IntegerUnion} - Base.depwarn("'ToricDivisorClass(v::NormalToricVarietyType, coeffs::Vector{T}) where {T <: IntegerUnion}' "* - "is deprecated, use 'toric_divisor_class(v::NormalToricVarietyType, coeffs::Vector{T}) "* - "where {T <: IntegerUnion}' instead.", :ToricDivisorClass) - toric_divisor_class(v, coeffs) -end - -function ToricDivisorClass(td::ToricDivisor) - Base.depwarn("'ToricDivisorClass(td::ToricDivisor)' is deprecated, use "* - "'toric_divisor_class(td::ToricDivisor) instead.", :ToricDivisorClass) - toric_divisor_class(td) -end - -function ToricLineBundle(v::NormalToricVarietyType, c::Vector{T}) where {T <: IntegerUnion} - Base.depwarn("'ToricLineBundle(v::NormalToricVarietyType, c::Vector{T}) where {T <: IntegerUnion}'"* - " is deprecated, use 'toric_line_bundle(v::NormalToricVarietyType, c::Vector{T}) where {T <: IntegerUnion}' "* - "instead.", :ToricLineBundle) - toric_line_bundle(v, c) -end - -function ToricLineBundle(v::NormalToricVarietyType, d::ToricDivisor) - Base.depwarn("'ToricLineBundle(v::NormalToricVarietyType, d::ToricDivisor)'"* - " is deprecated, use 'toric_line_bundle(v::NormalToricVarietyType, d::ToricDivisor)' "* - "instead.", :ToricLineBundle) - toric_line_bundle(v, d) -end - -function ToricLineBundle(d::ToricDivisor) - Base.depwarn("'ToricLineBundle(d::ToricDivisor)'"* - " is deprecated, use 'toric_line_bundle(d::ToricDivisor)' instead", :ToricLineBundle) - toric_line_bundle(d) -end - -function ToricMorphism(domain::NormalToricVarietyType, mapping_matrix::Vector{Vector{T}}, codomain::T2=nothing) where {T <: IntegerUnion, T2 <: Union{NormalToricVarietyType, Nothing}} - Base.depwarn("'ToricMorphism(domain::NormalToricVarietyType, mapping_matrix::Vector{Vector{T}}, codomain::T2=nothing) "* - "where {T <: IntegerUnion, T2 <: Union{NormalToricVarietyType, Nothing}}' is depcreated, use "* - "'toric_morphism(domain::NormalToricVarietyType, mapping_matrix::Vector{Vector{T}}, codomain::T2=nothing) "* - "where {T <: IntegerUnion, T2 <: Union{NormalToricVarietyType, Nothing}})' instead", :ToricMorphism) - toric_morphism(domain, mapping_matrix, codomain) -end - -function ToricMorphism(domain::NormalToricVarietyType, mapping_matrix::Matrix{T}, codomain::T2=nothing) where {T <: IntegerUnion, T2 <: Union{NormalToricVarietyType, Nothing}} - Base.depwarn("'ToricMorphism(domain::NormalToricVarietyType, mapping_matrix::Matrix{T}, codomain::T2=nothing) "* - "where {T <: IntegerUnion, T2 <: Union{NormalToricVarietyType, Nothing}}' is deprecated, use "* - "'toric_morphism(domain::NormalToricVarietyType, mapping_matrix::Matrix{T}, codomain::T2=nothing) "* - "where {T <: IntegerUnion, T2 <: Union{NormalToricVarietyType, Nothing}}' instead", :ToricMorphism) - toric_morphism(domain, mapping_matrix, codomain) -end - -function ToricMorphism(domain::NormalToricVarietyType, mapping_matrix::ZZMatrix, codomain::T=nothing) where {T <: Union{NormalToricVarietyType, Nothing}} - Base.depwarn("'ToricMorphism(domain::NormalToricVarietyType, mapping_matrix::ZZMatrix, codomain::T=nothing) "* - "where {T <: Union{NormalToricVarietyType, Nothing}}' is deprecated, use "* - "'toric_morphism(domain::NormalToricVarietyType, mapping_matrix::ZZMatrix, codomain::T=nothing) "* - "where {T <: Union{NormalToricVarietyType, Nothing}}' instead", :ToricMorphism) - toric_morphism(domain, mapping_matrix, codomain) -end - - -@deprecate ToricIdentityMorphism(v::NormalToricVarietyType) toric_identity_morphism(v) - -@deprecate induced_class_function induce -@deprecate radical_subgroup solvable_radical -@deprecate has_radical_subgroup has_solvable_radical -@deprecate set_radical_subgroup set_solvable_radical - -# `is_characteristic` had the wrong order of arguments, -# see https://github.com/oscar-system/Oscar.jl/issues/1793 -@deprecate is_characteristic(G::T, H::T) where T <: GAPGroup is_characteristic_subgroup(H, G) - -# `is_maximal` had the wrong order of arguments, -# see https://github.com/oscar-system/Oscar.jl/issues/1793 -@deprecate is_maximal(G::T, H::T) where T <: GAPGroup is_maximal_subgroup(H, G) - -# `is_normal` had the wrong order of arguments, -# see https://github.com/oscar-system/Oscar.jl/issues/1793 -@deprecate is_normal(G::T, H::T) where T <: GAPGroup is_normalized_by(H, G) - - -# Deprecated after 0.12.0 -@deprecate contains(P::Polyhedron, v::AbstractVector) Base.in(v, P) -@deprecate contains(C::Cone, v::AbstractVector) Base.in(v, C) -@deprecate blowup_on_ith_minimal_torus_orbit(v::NormalToricVarietyType, n::Int, coordinate_name::String; set_attributes::Bool = true) blow_up(v, n; coordinate_name = coordinate_name) -@deprecate starsubdivision(PF::_FanLikeType, n::Int) star_subdivision(PF, n) - -# Deprecated after 0.12.1 -@deprecate hirzebruch_surface(r::Int; set_attributes::Bool = true) hirzebruch_surface(NormalToricVariety, r) -@deprecate del_pezzo_surface(b::Int; set_attributes::Bool = true) del_pezzo_surface(NormalToricVariety, b) - -# PolyhedralComplex -> polyhedral_complex -function PolyhedralComplex{T}( - polyhedra::IncidenceMatrix, - vr::AbstractCollection[PointVector], - far_vertices::Union{Vector{Int}, Nothing} = nothing, - L::Union{AbstractCollection[RayVector], Nothing} = nothing; - non_redundant::Bool = false - ) where T<:scalar_types - Base.depwarn("'PolyhedralComplex{$T}(x...)' is deprecated, use 'polyhedral_complex($T, x...)' instead.", :PolyhedralComplex) - return polyhedral_complex(T, polyhedra, vr, far_vertices, L; non_redundant=non_redundant) -end -function PolyhedralComplex( - polyhedra::IncidenceMatrix, - vr::AbstractCollection[PointVector], - far_vertices::Union{Vector{Int}, Nothing} = nothing, - L::Union{AbstractCollection[RayVector], Nothing} = nothing; - non_redundant::Bool = false - ) - Base.depwarn("'PolyhedralComplex' is deprecated, use 'polyhedral_complex' instead.", :PolyhedralComplex) - return polyhedral_complex(QQFieldElem, polyhedra, vr, far_vertices, L; non_redundant=non_redundant) -end -function PolyhedralComplex(iter::SubObjectIterator{Polyhedron{T}}) where T<:scalar_types - Base.depwarn("'PolyhedralComplex' is deprecated, use 'polyhedral_complex' instead.", :PolyhedralComplex) - return polyhedral_complex(iter) -end -@deprecate PolyhedralComplex(p::Polymake.BigObject) polyhedral_complex(p) - -# PolyhedralFan -> polyhedral_fan -@deprecate PolyhedralFan(p::Polymake.BigObject) polyhedral_fan(p) -function PolyhedralFan{T}(Rays::AbstractCollection[RayVector], - LS::Union{AbstractCollection[RayVector], Nothing}, - Incidence::IncidenceMatrix; - non_redundant::Bool = false) where T<:scalar_types - Base.depwarn("'PolyhedralFan{$T}(x...)' is deprecated, use 'polyhedral_fan($T, x...)' instead.", :PolyhedralFan) - return polyhedral_fan(T, Incidence, Rays, LS; non_redundant=non_redundant) -end -function PolyhedralFan{T}(Rays::AbstractCollection[RayVector], Incidence::IncidenceMatrix; non_redundant::Bool = false) where T<:scalar_types - Base.depwarn("'PolyhedralFan{$T}(x...)' is deprecated, use 'polyhedral_fan($T, x...)' instead.", :PolyhedralFan) - return polyhedral_fan(T, Incidence, Rays; non_redundant=non_redundant) -end -@deprecate PolyhedralFan(Rays::AbstractCollection[RayVector], LS::Union{AbstractCollection[RayVector], Nothing}, Incidence::IncidenceMatrix; non_redundant::Bool = false) polyhedral_fan(QQFieldElem, Incidence, Rays, LS; non_redundant = non_redundant) -@deprecate PolyhedralFan(Rays::AbstractCollection[RayVector], Incidence::IncidenceMatrix; non_redundant::Bool = false) polyhedral_fan(QQFieldElem, Incidence, Rays; non_redundant = non_redundant) -function PolyhedralFan(itr::AbstractVector{Cone{T}}) where T<:scalar_types - Base.depwarn("'PolyhedralFan' is deprecated, use 'polyhedral_fan' instead.", :PolyhedralFan) - return polyhedral_fan(itr) -end -function PolyhedralFan(C::Cone{T}) where T<:scalar_types - Base.depwarn("'PolyhedralFan' is deprecated, use 'polyhedral_fan' instead.", :PolyhedralFan) - return polyhedral_fan(C) -end -function PolyhedralFan{T}(Rays::AbstractCollection[RayVector], LS::AbstractCollection[RayVector], Incidence::Matrix{Bool}) where T<:scalar_types - Base.depwarn("'PolyhedralFan{$T}(x...)' is deprecated, use 'polyhedral_fan($T, x...)' instead.", :PolyhedralFan) - return polyhedral_fan(T, Incidence, Rays, LS) -end -function PolyhedralFan{T}(Rays::AbstractCollection[RayVector], Incidence::Matrix{Bool}) where T<:scalar_types - Base.depwarn("'PolyhedralFan{$T}(x...)' is deprecated, use 'polyhedral_fan($T, x...)' instead.", :PolyhedralFan) - return polyhedral_fan(T, Incidence, Rays) -end - -# SubdivisionOfPoints -> subdivision_of_points -@deprecate SubdivisionOfPoints(points, C) subdivision_of_points(points, C) -function SubdivisionOfPoints{T}(points, C) where T<:scalar_types - Base.depwarn("'SubdivisionOfPoints{$T}(x...)' is deprecated, use 'subdivision_of_points($T, x...)' instead.", :SubdivisionOfPoints) - return subdivision_of_points(T, points, C) -end -@deprecate SubdivisionOfPoints(p::Polymake.BigObject) subdivision_of_points(p) - -# Polyhedron -> polyhedron -function Polyhedron{T}(first, second) where T<:scalar_types - Base.depwarn("'Polyhedron{$T}(x...)' is deprecated, use 'polyhedron($T, x...)' instead.", :Polyhedron) - return polyhedron(T, first, second) -end -@deprecate Polyhedron(A) polyhedron(A) -@deprecate Polyhedron(A, b) polyhedron(A, b) - -# Cone -> positive_hull -@deprecate Cone(R;kwargs...) positive_hull(R;kwargs...) -@deprecate Cone(R,L;kwargs...) positive_hull(R,L;kwargs...) -function Cone{T}(R, L; kwargs...) where T<:scalar_types - Base.depwarn("'Cone{$T}(x...)' is deprecated, use 'positive_hull($T, x...)' instead.", :Polyhedron) - return positive_hull(T, R, L; kwargs...) -end -function Cone{T}(R; kwargs...) where T<:scalar_types - Base.depwarn("'Cone{$T}(x...)' is deprecated, use 'positive_hull($T, x...)' instead.", :Polyhedron) - return positive_hull(T, R; kwargs...) -end - -# LinearProgram -> linear_program -function LinearProgram(p::Polyhedron{T}, lp, c) where T<:scalar_types - Base.depwarn("'LinearProgram(x...)' is deprecated, use 'linear_program(x...)' instead.", :LinearProgram) - return linear_program(p, lp, c) -end -function LinearProgram{T}(P::Polyhedron{T}, objective::AbstractVector; kwargs...) where T<:scalar_types - Base.depwarn("'LinearProgram(x...)' is deprecated, use 'linear_program(x...)' instead.", :LinearProgram) - return linear_program(P, objective; kwargs...) -end -function LinearProgram(P::Polyhedron{T}, objective::AbstractVector; kwargs...) where T<:scalar_types - Base.depwarn("'LinearProgram(x...)' is deprecated, use 'linear_program(x...)' instead.", :LinearProgram) - return linear_program(P, objective; kwargs...) -end -function LinearProgram{T}(A::Union{Oscar.MatElem,AbstractMatrix}, b, c::AbstractVector; kwargs...) where T<:scalar_types - Base.depwarn("'LinearProgram(x...)' is deprecated, use 'linear_program(x...)' instead.", :LinearProgram) - return linear_program(T, A, b, c; kwargs...) -end - - -# MixedIntegerLinearProgram -> mixed_integer_linear_program -function MixedIntegerLinearProgram(p::Polyhedron{T}, lp, c) where T<:scalar_types - Base.depwarn("'MixedIntegerLinearProgram(x...)' is deprecated, use 'mixed_integer_linear_program(x...)' instead.", :MixedIntegerLinearProgram) - return mixed_integer_linear_program(p, lp, c) -end -function MixedIntegerLinearProgram{T}(P::Polyhedron{T}, objective::AbstractVector; kwargs...) where T<:scalar_types - Base.depwarn("'MixedIntegerLinearProgram(x...)' is deprecated, use 'mixed_integer_linear_program(x...)' instead.", :MixedIntegerLinearProgram) - return mixed_integer_linear_program(P, objective; kwargs...) -end -function MixedIntegerLinearProgram(P::Polyhedron{T}, objective::AbstractVector; kwargs...) where T<:scalar_types - Base.depwarn("'MixedIntegerLinearProgram(x...)' is deprecated, use 'mixed_integer_linear_program(x...)' instead.", :MixedIntegerLinearProgram) - return mixed_integer_linear_program(P, objective; kwargs...) -end -function MixedIntegerLinearProgram{T}(A::Union{Oscar.MatElem,AbstractMatrix}, b, c::AbstractVector; kwargs...) where T<:scalar_types - Base.depwarn("'MixedIntegerLinearProgram(x...)' is deprecated, use 'mixed_integer_linear_program(x...)' instead.", :MixedIntegerLinearProgram) - return mixed_integer_linear_program(T, A, b, c; kwargs...) -end - -# see https://github.com/oscar-system/Oscar.jl/pull/2368 -@deprecate FreeModElem(coords::SRow{T}, parent::FreeMod_dec{T}) where T <: CRingElem_dec FreeModElem_dec(coords, parent) - -# see https://github.com/oscar-system/Oscar.jl/pull/2519 -@deprecate group_class_function(tbl::GAPGroupCharacterTable, values::GapObj) class_function(tbl, values) -@deprecate group_class_function(tbl::GAPGroupCharacterTable, values::Vector{<:QQAbElem}) class_function(tbl, values) -@deprecate group_class_function(G::GAPGroup, values::GapObj) class_function(G, values) -@deprecate group_class_function(G::GAPGroup, values::Vector{<:QQAbElem}) class_function(G, values) - -# Deprecated after 0.13.0 -@deprecate fan(v::NormalToricVarietyType) polyhedral_fan(v) -@deprecate restrict_automorphism_group(G::AutomorphismGroup{TorQuadModule}, i::TorQuadModuleMap, check::Bool) restrict_automorphism_group(G, i; check) - -# Polyhedral object wrappers now require a parent field -function Cone{T}(obj::Polymake.BigObject) where T<:scalar_types - Base.depwarn("'Cone{$T}(obj::Polymake.BigObject)' is deprecated, use 'Cone{$T}(obj, f)' with 'f::Field', or 'cone(obj)' instead.", :Cone) - return Cone{T}(obj, _detect_default_field(T, obj)) -end - -function PolyhedralComplex{T}(obj::Polymake.BigObject) where T<:scalar_types - Base.depwarn("'PolyhedralComplex{$T}(obj::Polymake.BigObject)' is deprecated, use 'PolyhedralComplex{$T}(obj, f)' with 'f::Field', or 'polyhedral_complex(obj)' instead.", :PolyhedralComplex) - return PolyhedralComplex{T}(obj, _detect_default_field(T, obj)) -end - -function PolyhedralFan{T}(obj::Polymake.BigObject) where T<:scalar_types - Base.depwarn("'PolyhedralFan{$T}(obj::Polymake.BigObject)' is deprecated, use 'PolyhedralFan{$T}(obj, f)' with 'f::Field', or 'polyhedral_fan(obj)' instead.", :PolyhedralFan) - return PolyhedralFan{T}(obj, _detect_default_field(T, obj)) -end - -function Polyhedron{T}(obj::Polymake.BigObject) where T<:scalar_types - Base.depwarn("'Polyhedron{$T}(obj::Polymake.BigObject)' is deprecated, use 'Polyhedron{$T}(obj, f)' with 'f::Field', or 'polyhedron(obj)' instead.", :Polyhedron) - return Polyhedron{T}(obj, _detect_default_field(T, obj)) -end - -function SubdivisionOfPoints{T}(obj::Polymake.BigObject) where T<:scalar_types - Base.depwarn("'SubdivisionOfPoints{$T}(obj::Polymake.BigObject)' is deprecated, use 'SubdivisionOfPoints{$T}(obj, f)' with 'f::Field', or 'subdivision_of_points(obj)' instead.", :SubdivisionOfPoints) - return SubdivisionOfPoints{T}(obj, _detect_default_field(T, obj)) -end - -@deprecate is_hermitian_matrix(B::MatElem{T}) where T <: FinFieldElem is_hermitian(B) -@alias ishermitian_matrix is_hermitian_matrix - -@deprecate is_alternating_form(f::SesquilinearForm) is_alternating(f) -@deprecate is_hermitian_form(f::SesquilinearForm) is_hermitian(f) -@deprecate is_quadratic_form(f::SesquilinearForm) is_quadratic(f) -@deprecate is_symmetric_form(f::SesquilinearForm) is_symmetric(f) - -@alias isalternating_form is_alternating_form -@alias ishermitian_form is_hermitian_form -@alias isquadratic_form is_quadratic_form -@alias issymmetric_form is_symmetric_form - -@deprecate dual_cone(v::AffineNormalToricVariety) weight_cone(v) -@deprecate cohomology_index(tvs::ToricVanishingSet) cohomology_indices(tvs) - -@deprecate mul(x::GAPGroupElem, y::GAPGroupElem) x*y - - -# see https://github.com/oscar-system/Oscar.jl/pull/2908 -function affine_normal_toric_variety(C::Cone, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :affine_normal_toric_variety) - return affine_normal_toric_variety(C) -end - -function normal_toric_variety(C::Cone, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :normal_toric_variety) - return normal_toric_variety(C) -end - -function affine_normal_toric_variety(v::NormalToricVariety, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :affine_normal_toric_variety) - return affine_normal_toric_variety(v) -end - -function normal_toric_variety(P::Polyhedron, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :normal_toric_variety) - return normal_toric_variety(P) -end - -function Base.:*(v::NormalToricVarietyType, w::NormalToricVarietyType, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :Base.:*) - return v*w -end - -function affine_space(::Type{NormalToricVariety}, d::Int, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :affine_space) - return affine_space(Type{NormalToricVariety}, d) -end - -function del_pezzo_surface(::Type{NormalToricVariety}, b::Int, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :del_pezzo_surface) - return del_pezzo_surface(Type{NormalToricVariety}, b) -end - -function hirzebruch_surface(::Type{NormalToricVariety}, r::Int, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :hirzebruch_surface) - return hirzebruch_surface(Type{NormalToricVariety}, r) -end - -function projective_space(::Type{NormalToricVariety}, d::Int, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :projective_space) - return projective_space(Type{NormalToricVariety}, d) -end - -function weighted_projective_space(::Type{NormalToricVariety}, w::Vector{T}, set_attributes::Bool) where {T <: IntegerUnion} - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :weighted_projective_space) - return weighted_projective_space(Type{NormalToricVariety}, w) -end - -function normal_toric_variety_from_star_triangulation(P::Polyhedron, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :normal_toric_variety_from_star_triangulation) - return normal_toric_variety_from_star_triangulation(P) -end - -function normal_toric_varieties_from_star_triangulations(P::Polyhedron, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :normal_toric_varieties_from_star_triangulations) - return normal_toric_varieties_from_star_triangulations(P) -end - -function blow_up(v::NormalToricVarietyType, new_ray::AbstractVector{<:IntegerUnion}, coordinate_name::String, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :blow_up) - return blow_up(v, new_ray, coordinate_name) -end - -function blow_up(v::NormalToricVarietyType, n::Int, coordinate_name::String, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :blow_up) - return blow_up(v, n, coordinate_name) -end - -function blow_up(v::NormalToricVarietyType, I::MPolyIdeal, coordinate_name::String, set_attributes::Bool) - Base.depwarn("The keyword argument set_attributes is deprecated. Please use the function without the keyword.", :blow_up) - return blow_up(v, I, coordinate_name) -end - -# Deprecated after 0.14.0 -@deprecate revlex(R::MPolyRing) invlex(R::MPolyRing) -@deprecate revlex(v::AbstractVector{<:MPolyRingElem}) invlex(v::AbstractVector{<:MPolyRingElem}) -@deprecate negrevlex(R::MPolyRing) ngeinvlex(R::MPolyRing) -@deprecate negrevlex(v::AbstractVector{<:MPolyRingElem}) neginvlex(v::AbstractVector{<:MPolyRingElem}) - -@deprecate polyhedral_fan(f::scalar_type_or_field, Rays::AbstractCollection[RayVector], Incidence::IncidenceMatrix; non_redundant::Bool = false) polyhedral_fan(f, Incidence, Rays, nothing; non_redundant) -@deprecate polyhedral_fan(Rays::AbstractCollection[RayVector], LS::Union{AbstractCollection[RayVector], Nothing}, Incidence::IncidenceMatrix; non_redundant::Bool = false) polyhedral_fan(QQFieldElem, Incidence, Rays, LS; non_redundant) -@deprecate polyhedral_fan(Rays::AbstractCollection[RayVector], Incidence::IncidenceMatrix; non_redundant::Bool = false) polyhedral_fan(QQFieldElem, Incidence, Rays; non_redundant) -@deprecate polyhedral_fan(f::scalar_type_or_field, - Rays::AbstractCollection[RayVector], - LS::Union{AbstractCollection[RayVector], Nothing}, - Incidence::IncidenceMatrix; - non_redundant::Bool = false) polyhedral_fan(f, Incidence, Rays, LS; non_redundant) -@deprecate polyhedral_fan(f::scalar_type_or_field, Rays::AbstractCollection[RayVector], LS::AbstractCollection[RayVector], Incidence::Matrix{Bool}) polyhedral_fan(f, Rays, LS, IncidenceMatrix(Polymake.IncidenceMatrix(Incidence))) -@deprecate polyhedral_fan(f::scalar_type_or_field, Rays::AbstractCollection[RayVector], Incidence::Matrix{Bool}) polyhedral_fan(f, Rays, IncidenceMatrix(Polymake.IncidenceMatrix(Incidence))) -@deprecate normal_toric_variety(rays::AbstractCollection[RayVector], max_cones::IncidenceMatrix; non_redundant::Bool = false) normal_toric_variety(max_cones, rays; non_redundant) - -@deprecate components(X::AbsSpec) connected_components(X::AbsSpec) - -@deprecate SimplicialComplex(generators::Union{AbstractVector{<:AbstractVector{<:Base.Integer}}, AbstractVector{<:AbstractSet{<:Base.Integer}}}) simplicial_complex(generators) -@deprecate SimplicialComplex(generators::IncidenceMatrix) simplicial_complex(generators) - -Base.@deprecate_binding is_finitelygenerated is_finitely_generated -Base.@deprecate_binding has_is_finitelygenerated has_is_finitely_generated -Base.@deprecate_binding set_is_finitelygenerated set_is_finitely_generated - -Base.@deprecate_binding is_obviouslyabelian is_obviously_abelian false - -Base.@deprecate_binding is_almostsimple is_almost_simple -Base.@deprecate_binding has_is_almostsimple has_is_almost_simple -Base.@deprecate_binding set_is_almostsimple set_is_almost_simple - # Deprecated after 0.14.* Base.@deprecate_binding is_isomorphic_with_symmetric_group is_isomorphic_to_symmetric_group Base.@deprecate_binding has_is_isomorphic_with_symmetric_group has_is_isomorphic_to_symmetric_group @@ -537,90 +13,6 @@ Base.@deprecate_binding are_algebraically_independent is_algebraically_independe Base.@deprecate ambient_ring(U::AbsMultSet) ring(U) -Base.@deprecate_binding hall_subgroups_representatives hall_subgroup_reps -Base.@deprecate_binding hasrelshp has_relshp -Base.@deprecate_binding hastorusfactor has_torusfactor -Base.@deprecate_binding inner_automorphisms_group inner_automorphism_group -Base.@deprecate_binding isaffine is_affine -Base.@deprecate_binding isalmostsimple is_almost_simple -Base.@deprecate_binding isample is_ample -Base.@deprecate_binding isbicoset is_bicoset -Base.@deprecate_binding isbinomial is_binomial -Base.@deprecate_binding isbounded is_bounded -Base.@deprecate_binding iscartier is_cartier -Base.@deprecate_binding iscellular is_cellular -Base.@deprecate_binding iscomplete is_complete -Base.@deprecate_binding iscongruent is_congruent -Base.@deprecate_binding isconjugate_subgroup is_conjugate_subgroup -Base.@deprecate_binding isdecorated is_decorated -Base.@deprecate_binding isdihedral_group is_dihedral_group -Base.@deprecate_binding isfano is_fano -Base.@deprecate_binding isfeasible is_feasible -Base.@deprecate_binding isfiltered is_filtered -Base.@deprecate_binding isfinite_order is_finiteorder -Base.@deprecate_binding isfinitelygenerated is_finitely_generated -Base.@deprecate_binding isfull_direct_product is_full_direct_product -Base.@deprecate_binding isfull_semidirect_product is_full_semidirect_product -Base.@deprecate_binding isfull_wreath_product is_full_wreath_product -Base.@deprecate_binding isfulldimensional is_fulldimensional -Base.@deprecate_binding isgenerated_by_standard_unit_vectors is_generated_by_standard_unit_vectors -Base.@deprecate_binding isglobal is_global -Base.@deprecate_binding isgraded is_graded -Base.@deprecate_binding isinner_automorphism is_inner_automorphism -Base.@deprecate_binding isinvariant is_invariant -Base.@deprecate_binding isisomorphic_with_alternating_group is_isomorphic_to_alternating_group -Base.@deprecate_binding isisomorphic_with_symmetric_group is_isomorphic_to_symmetric_group -Base.@deprecate_binding isleft is_left -Base.@deprecate_binding islocal is_local -Base.@deprecate_binding ismixed is_mixed -Base.@deprecate_binding ismolien_series_implemented is_molien_series_implemented -Base.@deprecate_binding isnatural_alternating_group is_natural_alternating_group -Base.@deprecate_binding isnatural_symmetric_group is_natural_symmetric_group -Base.@deprecate_binding isnef is_nef -Base.@deprecate_binding isobviouslyabelian is_obviously_abelian false -Base.@deprecate_binding isorbifold is_orbifold -Base.@deprecate_binding isperfect is_perfect -Base.@deprecate_binding ispgroup is_pgroup -Base.@deprecate_binding ispointed is_pointed -Base.@deprecate_binding isprojective is_projective -Base.@deprecate_binding ispure is_pure -Base.@deprecate_binding isquaternion_group is_quaternion_group -Base.@deprecate_binding isright is_right -Base.@deprecate_binding issemiregular is_semiregular -Base.@deprecate_binding issemisimple is_semisimple -Base.@deprecate_binding issimplicial is_simplicial -Base.@deprecate_binding issingular is_singular -#Base.@deprecate_binding issmooth_curve is_smooth_curve -Base.@deprecate_binding issolvable is_solvable -Base.@deprecate_binding issupersolvable is_supersolvable -Base.@deprecate_binding istransitive is_transitive -Base.@deprecate_binding isunipotent is_unipotent -Base.@deprecate_binding isunital is_unital -Base.@deprecate_binding iswelldefined is_welldefined -Base.@deprecate_binding representative_action is_conjugate_with_data -Base.@deprecate_binding representative_action_in_gl_or_sl is_conjugate_with_data_in_gl_or_sl - -Base.@deprecate_binding has_isfinite has_is_finite -Base.@deprecate_binding SymmetricGroup symmetric_group - -# Allow backwards compatibility after removal of Oscar.Graphs module. -const Graphs = Oscar - -Base.@deprecate_binding MPolyElem_dec MPolyDecRingElem -Base.@deprecate_binding MPolyRing_dec MPolyDecRing -Base.@deprecate_binding MPolyLocalizedRingElem MPolyLocRingElem -Base.@deprecate_binding MPolyLocalizedRing MPolyLocRing -Base.@deprecate_binding MPolyQuoElem MPolyQuoRingElem -Base.@deprecate_binding MPolyQuo MPolyQuoRing -Base.@deprecate_binding MPolyQuoLocalizedRingElem MPolyQuoLocRingElem -Base.@deprecate_binding MPolyQuoLocalizedRing MPolyQuoLocRing -Base.@deprecate_binding SubQuoElem SubquoModuleElem -Base.@deprecate_binding SubQuo SubquoModule -#@alias SubQuoElem_dec SubquoDecModuleElem -#@alias SubQuo_dec SubquoDecModule -Base.@deprecate_binding GradedPolynomialRing graded_polynomial_ring - - # Deprecated after 0.15 Base.@deprecate_binding _compute_glueing_base_change _compute_gluing_base_change Base.@deprecate_binding _compute_inherited_glueing _compute_inherited_gluing @@ -663,8 +55,6 @@ Base.@deprecate_binding jacobi_ideal jacobian_ideal @deprecate n_maximal_cells number_of_maximal_cells @deprecate n_maximal_cones number_of_maximal_cones @deprecate n_maximal_polyhedra number_of_maximal_polyhedra -@deprecate ne number_of_edges -@deprecate nv number_of_vertices @deprecate num_partitions number_of_partitions @deprecate num_positive_roots number_of_positive_roots @deprecate num_roots number_of_roots diff --git a/src/exports.jl b/src/exports.jl index a4533346a5b6..35f5e016000a 100644 --- a/src/exports.jl +++ b/src/exports.jl @@ -72,7 +72,6 @@ export GSet export GU export Gluing export Graph -export Graphs export GroupConjClass export GroupCoset export GroupDoubleCoset @@ -516,7 +515,6 @@ export facet_sizes export facets export factor_of_direct_product export factorisations -export fan export fano_matroid export fano_simplex export fat_ideal @@ -1489,7 +1487,6 @@ export vertexindices export vertical_connectivity export vertices export vertices_and_rays -export vf_group export visualize export volume export volume_form