Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow controllers are not exported correctly #278

Closed
juona opened this issue May 25, 2021 · 1 comment
Closed

Flow controllers are not exported correctly #278

juona opened this issue May 25, 2021 · 1 comment

Comments

@juona
Copy link

juona commented May 25, 2021

The index file is supposed to export all the flow controllers at the end of the file:

// Export all flow controllers and the main concurrently function,
// so that 3rd-parties can use them however they want
exports.concurrently = concurrently;
exports.Logger = Logger;
exports.InputHandler = InputHandler;

This does not work because you have redefined module.exports and exports no longer references module.exports:

module.exports = (commands, options = {}) => { /*...*/ };

// This will not export anything
exports.Logger = Logger;

A simple fix is to use module.exports everywhere instead of exports.

@gustavohenke
Copy link
Member

🤦 thanks for catching this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants