Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning with Node 22 #477

Closed
Urmeli0815 opened this issue May 19, 2024 · 8 comments · Fixed by #479
Closed

Deprecation warning with Node 22 #477

Urmeli0815 opened this issue May 19, 2024 · 8 comments · Fixed by #479

Comments

@Urmeli0815
Copy link

Urmeli0815 commented May 19, 2024

After upgrading to Node 22 we get a deprecation warning DEP0060 caused by the dependency spawn-command:

at module.exports (...\node_modules\spawn-command\lib\spawn-command.js:9)
at Proxy.start (...\node_modules\concurrently\dist\src\command.js:55:28)
...

The code that causes that is this line

The fix looks trivial but spawn-command doesn't seem to be developed anymore. Maybe the functionality could be integrated in concurrently.

@Urmeli0815 Urmeli0815 changed the title Deprecation warning with Node 20 Deprecation warning with Node 22 May 19, 2024
@gustavohenke
Copy link
Member

Thanks for raising this. I agree that we can integrate it into concurrently.

@moritz-baecker-integra
Copy link

Are you sure, that you want to include the functionality into concurrently?
https://www.npmjs.com/package/spawn-command
seems to be active, because the problem got fixed

@PatrykKuniczak
Copy link

@gustavohenke Are you able to realase this soon?
I want to bump node to 22 on my project, but i don't want with this error :)

@theonlypwner
Copy link

theonlypwner commented Sep 2, 2024

mmalecki/spawn-command#9 was fixed, so that dependency wasn't actually unmaintained.

Instead of including its code in this repo, it would be easier to just bump spawn-command to 0.0.3 in package.json.

@gustavohenke
Copy link
Member

Hi folks, sorry for the delay, this is now fixed in v9.0.0.
https://github.com/open-cli-tools/concurrently/releases/tag/v9.0.0

@Urmeli0815
Copy link
Author

Urmeli0815 commented Sep 9, 2024

@gustavohenke Thanks for the release. The good news is that the warning is gone. The bad news is that I get a new one now :)

Generate source code (12 tasks) ...
 0% | ETA: 0s | 0/12(node:14748) MaxListenersExceededWarning: Possible EventTarget memory leak detected. 11 abort listeners added to [AbortSignal]. MaxListenert
    at [kNewListener] (node:internal/event_target:562:17)
    at [kNewListener] (node:internal/abort_controller:268:24)
    at AbortSignal.addEventListener (node:internal/event_target:675:23)
    at mycheckout\node_modules\rxjs\dist\cjs\internal\observable\fromEvent.js:38:111
    at Observable._subscribe (mycheckout\node_modules\rxjs\dist\cjs\internal\observable\fromEvent.js:61:9)
    at Observable._trySubscribe (mycheckout\node_modules\rxjs\dist\cjs\internal\Observable.js:41:25)
    at mycheckout\node_modules\rxjs\dist\cjs\internal\Observable.js:35:31
    at Object.errorContext (mycheckout\node_modules\rxjs\dist\cjs\internal\util\errorContext.js:22:9)
    at Observable.subscribe (mycheckout\node_modules\rxjs\dist\cjs\internal\Observable.js:26:24)
    at Object.mergeInternals (mycheckout\node_modules\rxjs\dist\cjs\internal\operators\mergeInternals.js:56:12)

In my case I start over 300 tasks (in the worst case) using concurrently. But the warning appears as soon as I have more than 10 tasks.

I also noticed that the exited property of these tasks never seems to be set, even when the task finished correctly. I display a progress bar and for the progress count all tasks in the exited state.

@gustavohenke
Copy link
Member

Ok, let's start a new issue for this one please

@Urmeli0815
Copy link
Author

I created #502.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants