logger: do not trim prefix #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavohenke
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
Thanks for doing this!
I actually checked old code to see if prefix trimming ever was a thing, and no. I introduced it out of the blue with the programmatic API 🤔
Normally I'd DRY it up a bit with test generators or a beforeEach, but I'm unsure if that is a welcome change.
It would yes! As long as it's done in a separate commit/PR, it's all good 👍
|
Proceeded with the merge in case you don't have time/don't feel like tidying up the tests. |
Closed
|
Release as v5.3.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logger should preserve any leading/trailing white space provided in the prefix
Closes #227
Side note: I'm keeping boilerplate code here just because I see it within the rest of the logger specification. Normally I'd DRY it up a bit with test generators or a
beforeEach, but I'm unsure if that is a welcome change.