Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples for the --passthrough-arguments parameter #480

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

mark-monteiro
Copy link
Contributor

@mark-monteiro mark-monteiro commented May 27, 2024

The existing examples are quite vague and do not fully describe how the feature works

The improved examples I've added here were taken directly from the original PR implementing this feature:
#307

@coveralls
Copy link

coveralls commented May 27, 2024

Coverage Status

coverage: 99.134% (-0.2%) from 99.343%
when pulling a0ffa77 on mark-monteiro:patch-1
into c700980 on open-cli-tools:main.

@mark-monteiro mark-monteiro force-pushed the patch-1 branch 2 times, most recently from 09fb468 to 1d93ecc Compare May 27, 2024 19:05
@mark-monteiro mark-monteiro marked this pull request as ready for review May 27, 2024 19:10
@mark-monteiro
Copy link
Contributor Author

Don't know how to make the linter happy. Everything passes when running locally 🤷

Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. I pushed a lint fix commit for you

@gustavohenke gustavohenke merged commit 3dc909a into open-cli-tools:main Jun 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants