-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qemu does not default to host capabilities for cap-{sbbc,cfpc,ibs} and needs clarity on usecase scenarios of these machine property #35
Comments
------- Comment From surajjs@au1.ibm.com 2018-02-07 17:57:33 EDT------- Previously qemu would query kvm capabilities from the hypervisor and would default to what the hypervisor was capable of. This was problematic as it meant that guests started with the exact same command line could be presented a different environment depending on the host they are started on. The entire idea of spapr-caps is to NOT infer any capabilities from the host and instead require they be explicitly stated on the command line, otherwise the default will be given. The values of these caps is then checked against the host capabilities and qemu will fail to start if the requested values are unavailable. Answering your questions: "Booting with Indirect branch serialisation apart from A: Booting with any option the host can't support will fail. If this is the case then the host cannot support anything other than broken for that option. Note that specific option depends on "fw-bcctrl-serialized" being set to enabled in the device tree so you can check that on the host if you are unsure. "why can't qemu emulates the default host capabilities available rather defaults to A: Because the whole idea of spapr-caps is to give a consistent guest environment for a given command line, not to default to whatever the host can do. The default is broken and so that will be used unless set otherwise. "If qemu-kvm has the control on these capabilities and aswell user can not override them what would be the usecase of exporting these machine properties to user and who will be using them" A: That is incorrect, the user CAN override them. If they want anything other than the default then they are required to. The idea is to provide spapr-caps to some higher level management layer which can use them to ensure consistency across a machine pool to provide migration compatibility. As far as I can see everything raised here is the system working as expected. |
------- Comment From satheera@in.ibm.com 2018-02-08 01:00:03 EDT------- > "why can't qemu emulates the default host capabilities available rather Sure, migration of guest from unpatched host --> patched host, will work but will leave the In other words live migration is not supported for side-channel fixes and anyways guest kernel needs a reboot, so it makes sense not to break migration work flow. > As far as I can see everything raised here is the system working as expected. Thanks for the explain :-), So libvirt and other management layers need to know about these capabilities of machine, not sure we already have support for them in libvirt, will check and raise a BZ to get that in. P:S:- I prefer the bug to be closed as Regards, |
------- Comment From surajjs@au1.ibm.com 2018-02-08 19:10:13 EDT------- Yes, the guest would need to be rebooted and the command line changed on the new host to get the fixes. This is because there is no way after the guest has booted to tell it it's environment has changed, as with most features. > |
------- Comment From lagarcia@br.ibm.com 2018-02-28 10:22:04 EDT------- |
------- Comment From seg@us.ibm.com 2018-09-14 12:52:10 EDT------- |
cde:info Mirrored with LTC bug https://bugzilla.linux.ibm.com/show_bug.cgi?id=164306 </cde:info>
Currently the machine properties cap-{sbbc,cfpc,ibs} are defaulted to
broken
irrespective of host hasworkaround/broken.
Host:
Guest:
Kernel: 4.15.0-3.dev.gitd34a158.el7.centos.ppc64le
Just boot a default guest:
whereas boot explicitly with those side channel capabilities
broken
fails to start guest?and without FW fix, qemu-kvm is not allowing user to boot with
workaround
for cfpc and sbbc aswell.i) From this it look like qemu-kvm while starting the guest validates whether or not host has these capabilities to emulate to guest, if then why can't qemu emulates the default host capabilities available rather defaults to
broken
always?ii) If qemu-kvm has the control on these capabilities and aswell user can not override them what would be the usecase of exporting these machine properties to user and who will be using them?, provided I guess we want to keep the libvirt out of context on these capabilities?
The text was updated successfully, but these errors were encountered: