Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other issue]: builder-rosdep.Dockerfile for jazzy #38

Open
1 task done
cwrx777 opened this issue Jun 19, 2024 · 3 comments
Open
1 task done

[Other issue]: builder-rosdep.Dockerfile for jazzy #38

cwrx777 opened this issue Jun 19, 2024 · 3 comments

Comments

@cwrx777
Copy link

cwrx777 commented Jun 19, 2024

Before proceeding, is there an existing issue or discussion for this?

Description

Does this section need to be updated for jazzy?

RUN if [ "$ROS_DISTRO" = "humble" ]; then \
      apt update && apt install -y \
        clang-13 \
        lldb-13 \
        lld-13 \
        ros-humble-rmw-cyclonedds-cpp \
        && rm -rf /var/lib/apt/lists/* \
      && update-alternatives --install /usr/bin/c++ c++ /usr/bin/clang++-13 100; \
    fi
@aaronchongth
Copy link
Member

aaronchongth commented Jun 24, 2024

Hi @cwrx777! Yes, it will need to be, if you are using jazzy.

For now we would still recommend using rmw-cyclonedds-cpp as it has worked well in live environments, but we may revisit the preferred rmw implementation some time soon, especially with our new jazzy releases.

edit: As for clang usage, although gcc works out of the box with jazzy we have noticed improvements when continuing to use clang, so it will probably remain the default for us

@cwrx777
Copy link
Author

cwrx777 commented Jun 24, 2024

@aaronchongth how about the compiler?

@aaronchongth
Copy link
Member

edit: As for clang usage, although gcc works out of the box with jazzy we have noticed improvements when continuing to use clang, so it will probably remain the default for us

@cwrx777 sorry forgot to post the link where we had this discussion, open-rmf/rmf_ci_templates#10 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants