Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestAgentIdentification/ws is flaky #191

Closed
tigrannajaryan opened this issue Jul 7, 2023 · 4 comments
Closed

TestAgentIdentification/ws is flaky #191

tigrannajaryan opened this issue Jul 7, 2023 · 4 comments
Assignees
@srikanthccv
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@tigrannajaryan
Copy link
Member

See https://github.com/open-telemetry/opamp-go/actions/runs/5487663480/jobs/9999430522

I can sometimes reproduce this locally by doing go test -run TestAgentIdentification/ws -race -count 1000
@tigrannajaryan tigrannajaryan added bug Something isn't working help wanted Extra attention is needed labels Jul 7, 2023
@srikanthccv
Copy link
Member

Another case https://github.com/open-telemetry/opamp-go/actions/runs/6248732304/job/16963976273

@srikanthccv srikanthccv self-assigned this Sep 20, 2023
@tigrannajaryan
Copy link
Member Author

Failed again: https://github.com/open-telemetry/opamp-go/actions/runs/6551109455/job/17791657822?pr=207

@haoqixu haoqixu mentioned this issue Dec 1, 2023
Closed
@tpaschalis
Copy link
Member

I couldn't reproduce any failures even after >40k tries with $ go test -run TestAgentIdentification/ws -race -count 10000 ./.... Also, these old action runs no longer have any logs associated with them.

The TestAgentIdentification case has been made more realistic after #286 and seems stable, so do we think it'd be a good idea to close this issue out?

@tigrannajaryan
Copy link
Member Author

Sounds good to me, let's close. We will reopen if we see the failure again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanthccv srikanthccv

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky TestAgentIdentification/ws haoqixu/opamp-go
3 participants
@tigrannajaryan @tpaschalis @srikanthccv